data.coop/ansible
8
3
Fork 7
Code Issues 49 Pull requests 9 Projects 1 Releases Wiki Activity

Enable Watchtower for all services #123

Merged
valberg merged 19 commits from watchtower into main 2023-01-21 17:17:56 +00:00
Conversation 16 Commits 19 Files changed 13 +3 -4
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit a4a06d8a58 - Show all commits

7
roles/docker/tasks/services/watchtower.yml
View file

@ -2,13 +2,12 @@
- name: watchtower container - name: watchtower container
docker_container: docker_container:
name: watchtower name: watchtower
image: containrrr/watchtower:1.4.0 image: containrrr/watchtower:latest
samsapti marked this conversation as resolved Outdated
valberg commented 2022-11-19 16:15:53 +00:00
Outdated
Review
Copy link

Let's pin this to a version instead of latest.

Let's pin this to a version instead of latest.
samsapti commented 2022-11-19 16:48:18 +00:00
Outdated
Review
Copy link

Why not latest?

Why not latest?
valberg commented 2022-11-19 17:00:02 +00:00
Outdated
Review
Copy link

Because I want to avoid confusion due to an unintended upgrade.

Because I want to avoid confusion due to an unintended upgrade.
samsapti commented 2022-11-19 17:05:18 +00:00
Outdated
Review
Copy link

I don't fully agree. I think it's better to always use the latest version security-wise, especially when it has access to the Docker socket.

I don't fully agree. I think it's better to always use the latest version security-wise, especially when it has access to the Docker socket.
valberg commented 2022-11-19 17:14:10 +00:00
Outdated
Review
Copy link

I agree, and we should strive to upgrade whenever a new version is available. But I don't want stuff to suddenly break behaviour without us knowing why.

I agree, and we should strive to upgrade whenever a new version is available. But I don't want stuff to suddenly break behaviour without us knowing why.
samsapti commented 2022-11-19 17:17:43 +00:00
Outdated
Review
Copy link

I'll pin it then. GitHub supports RSS feeds for releases, maybe we could use that to be notified about new releases? We could set up notifications in our Matrix channel somehow.

https://github.com/containrrr/watchtower/releases.atom

I'll pin it then. GitHub supports RSS feeds for releases, maybe we could use that to be notified about new releases? We could set up notifications in our Matrix channel somehow. https://github.com/containrrr/watchtower/releases.atom
👍 1
valberg commented 2022-11-19 17:19:28 +00:00
Outdated
Review
Copy link

Sounds like a great idea!

Sounds like a great idea!
👍 1
restart_policy: unless-stopped restart_policy: unless-stopped
env:
WATCHTOWER_POLL_INTERVAL: 60
networks: networks:
- name: external_services - name: external_services
volumes: volumes:
- /var/run/docker.sock:/var/run/docker.sock - /var/run/docker.sock:/var/run/docker.sock
- "{{ docker_registry.volume_folder }}/auth/config.json:/config.json" - "{{ docker_registry.volume_folder }}/auth/config.json:/config.json"
samsapti marked this conversation as resolved Outdated
valberg commented 2022-11-19 16:15:10 +00:00
Outdated
Review
Copy link

This means that docker-registry should be run before watchtower right?

This means that `docker-registry` should be run before `watchtower` right?
samsapti commented 2022-11-19 16:47:12 +00:00
Outdated
Review
Copy link

Yes, which is currently also the case.

Yes, which is currently also the case.
👍 1
env:
WATCHTOWER_LABEL_ENABLE: "true"
WATCHTOWER_POLL_INTERVAL: "60"
samsapti marked this conversation as resolved Outdated
valberg commented 2023-01-21 12:14:29 +00:00
Outdated
Review
Copy link

Hvordan er det nu at services der skal opdateres bliver fundet hvis det ikke er via label?

Hvordan er det nu at services der skal opdateres bliver fundet hvis det ikke er via label?