data.coop/membersystem
7
2
Fork 4
Code Issues 14 Pull requests 1 Releases Wiki Activity

Undocumented devenv/NixOS and Poetry stuff #34

New issue
Closed
opened 2024-07-14 17:35:57 +00:00 by benjaoming · 9 comments
benjaoming commented 2024-07-14 17:35:57 +00:00
Owner
Copy link

I'm confused about how to get a functional development running. The current README doesn't quite play and doesn't align with the Poetry stuff in the Makefile, nor the devenv files.

Currently, the default environment (.env.example) has DEBUG=True and that's fine. The thing is that django_debug_toolbar is part of the requirements for a development environment and it isn't installed.

I'll try to add some fixes for this now...

I'm confused about how to get a functional development running. The current README doesn't quite play and doesn't align with the Poetry stuff in the Makefile, nor the devenv files. Currently, the default environment (`.env.example`) has `DEBUG=True` and that's fine. The thing is that django_debug_toolbar is part of the requirements for a development environment and it isn't installed. I'll try to add some fixes for this now...
benjaoming commented 2024-07-14 18:07:47 +00:00
Author
Owner
Copy link

Hmm, not easy from a train... the COPY --chown=www:www . . line in Dockerfile is invalidating the Docker cache all the time... moving it so we can cache more build stages....

Hmm, not easy from a train... the `COPY --chown=www:www . .` line in Dockerfile is invalidating the Docker cache all the time... moving it so we can cache more build stages....
valberg commented 2024-07-14 18:40:04 +00:00
Owner
Copy link

Yeah this stuff is pretty much defunct and outdated. I'll do an update of the readme and the different files.

Yeah this stuff is pretty much defunct and outdated. I'll do an update of the readme and the different files.
valberg commented 2024-07-14 18:41:03 +00:00
Owner
Copy link

The project uses hatch, so there is a clear path for development - it is just not documented

The project uses hatch, so there is a clear path for development - it is just not documented
benjaoming commented 2024-07-14 18:42:43 +00:00
Author
Owner
Copy link

So the whole Makefile is dead? 😱

So the whole Makefile is dead? 😱
valberg commented 2024-07-14 18:46:47 +00:00
Owner
Copy link

Hah hah, not dead per se, more like just not working. Should nt take long to fix it.

Hah hah, not dead per se, more like just not working. Should nt take long to fix it.
benjaoming commented 2024-07-14 18:58:37 +00:00
Author
Owner
Copy link

I'm gonna try to clean up the Dockerfile and the README to align with the Hatch commands...

I'm gonna try to clean up the Dockerfile and the README to align with the Hatch commands...
benjaoming commented 2024-07-14 18:59:29 +00:00
Author
Owner
Copy link

Please, for future reference, don't change all the entrypoints in a project without some kind of note in the README... even knowing that the README isn't updated is helpful :)

Please, for future reference, don't change all the entrypoints in a project without some kind of note in the README... even knowing that the README isn't updated is helpful :)
valberg commented 2024-07-14 19:04:52 +00:00
Owner
Copy link

@benjaoming I'm cleaning it up

And please don't "please" - I've been the sole developer on this project for quite some time, so stuff has been a bit messy because I haven't had the motivation to clean things up ;) But now I really want to clean it up because you want to do stuff!

@benjaoming I'm cleaning it up And please don't "please" - I've been the sole developer on this project for quite some time, so stuff has been a bit messy because I haven't had the motivation to clean things up ;) But now I really want to clean it up because you want to do stuff!
valberg commented 2024-07-14 21:14:56 +00:00
Owner
Copy link

Closed in 480eecca12

Closed in https://git.data.coop/data.coop/membersystem/commit/480eecca12e3e3c1cde583169791137365bb9a9c
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
services
keycloak
stripe
vidir_refactor
feature/allauth-for-accounts
No results found.
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: data.coop/membersystem#34
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?