data.coop/membersystem
7
2
Fork 4
Code Issues 14 Pull requests 1 Releases Wiki Activity

Membership invitations and order emails #47

Merged
valberg merged 10 commits from benjaoming/membersystem:membership-invite into main 2024-08-14 09:17:30 +00:00
Conversation 1 Commits 10 Files changed 21 +5 -2
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 1c740418f4 - Show all commits

7
src/membership/admin.py
View file

@ -126,13 +126,16 @@ class MemberAdmin(UserAdmin):
if member.is_active: if member.is_active:
messages.error( messages.error(
request, request,
f"This member will not receive an invite because the account is marked as active: {member.email}", f"Computer says no! This member will not receive an invite because the account is marked "
f"as active: {member.email}. That means the member has probably created a password and a username "
f"already, please tell them to use the password reminder function.",
) )
continue continue
if not member.memberships.current(): if not member.memberships.current():
messages.error( messages.error(
benjaoming marked this conversation as resolved
valberg commented 2024-08-14 05:12:50 +00:00
Review
Copy link

Is the idea not that the member does not have a membership and thus should be sent an invite?

Is the idea not that the member does not have a membership and thus should be sent an invite?
benjaoming commented 2024-08-14 07:53:25 +00:00
Review
Copy link

I've replaced "active" with "current" - the idea is that we should not invite members before we have also created their membership + order (there's another admin function for that).

Once the actions are defined, we can maybe merge some of the stuff into a single-click action... but I just wanna make sure that we keep the flexibility for now.. until the whole signup/apply process is defined.

I've replaced "active" with "current" - the idea is that we should not invite members before we have also created their membership + order (there's another admin function for that). Once the actions are defined, we can maybe merge some of the stuff into a single-click action... but I just wanna make sure that we keep the flexibility for now.. until the whole signup/apply process is defined.
request, request,
f"This member will not receive an invite because it has no active membership: {member.email}", f"Computer says no! This member will not receive an invite because it has no current "
f"membership: {member.email}. You need to create a current membership before sending the invite.",
) )
continue continue
membership = member.memberships.current() membership = member.memberships.current()