data.coop/pinafore
8
0
Fork 0
Code Issues 1 Pull requests Packages Projects Releases Wiki Activity

guard against NPEs for IntersectionObserver

Browse source
This commit is contained in:
Nolan Lawson 2018-01-23 21:02:51 -08:00
parent 2a215480e2
commit 0a7f56004f
1 changed files with 13 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
routes/_utils/AsyncLayout.js
View file

@ -14,24 +14,30 @@ class AsyncLayout {
} }
observe(key, node, callback) { observe(key, node, callback) {
this._onIntersectionCallbacks[key] = (entry) => { if (this._intersectionObserver) {
callback(getRectFromEntry(entry)) this._onIntersectionCallbacks[key] = (entry) => {
this.unobserve(key, node) callback(getRectFromEntry(entry))
this.unobserve(key, node)
}
this._intersectionObserver.observe(node)
} }
this._intersectionObserver.observe(node)
} }
unobserve(key, node) { unobserve(key, node) {
if (key in this._onIntersectionCallbacks) { if (key in this._onIntersectionCallbacks) {
return return
} }
this._intersectionObserver.unobserve(node) if (this._intersectionObserver) {
this._intersectionObserver.unobserve(node)
}
delete this._onIntersectionCallbacks[key] delete this._onIntersectionCallbacks[key]
} }
disconnect() { disconnect() {
this._intersectionObserver.disconnect() if (this._intersectionObserver) {
this._intersectionObserver = null this._intersectionObserver.disconnect()
this._intersectionObserver = null
}
} }
} }