From 3971f9a6368c3fef1fff93b8bc370304117137dd Mon Sep 17 00:00:00 2001
From: Nolan Lawson <nolan@nolanlawson.com>
Date: Tue, 11 May 2021 21:40:40 -0700
Subject: [PATCH] fix: switch to native :focus-visible for firefox 88+ (#2039)

---
 src/routes/_utils/supportsFocusVisible.js     |  6 +++---
 src/routes/_utils/userAgent/isFirefox.js      |  8 +++++---
 src/routes/_utils/userAgent/isFirefoxPre88.js | 17 +++++++++++++++++
 3 files changed, 25 insertions(+), 6 deletions(-)
 create mode 100644 src/routes/_utils/userAgent/isFirefoxPre88.js

diff --git a/src/routes/_utils/supportsFocusVisible.js b/src/routes/_utils/supportsFocusVisible.js
index 75f1df38..c2393384 100644
--- a/src/routes/_utils/supportsFocusVisible.js
+++ b/src/routes/_utils/supportsFocusVisible.js
@@ -1,7 +1,7 @@
 import { thunk } from './thunk'
 import { supportsSelector } from './supportsSelector'
-import { isFirefox } from './userAgent/isFirefox'
+import { isFirefoxPre88 } from './userAgent/isFirefoxPre88'
 
-// TODO: remove the Firefox check once this bug is fixed
+// Firefox pre-88 had a focus-visible bug:
 // https://bugzilla.mozilla.org/show_bug.cgi?id=1699154
-export const supportsFocusVisible = thunk(() => (!isFirefox() && supportsSelector(':focus-visible')))
+export const supportsFocusVisible = thunk(() => (!isFirefoxPre88() && supportsSelector(':focus-visible')))
diff --git a/src/routes/_utils/userAgent/isFirefox.js b/src/routes/_utils/userAgent/isFirefox.js
index e431fc0b..af315343 100644
--- a/src/routes/_utils/userAgent/isFirefox.js
+++ b/src/routes/_utils/userAgent/isFirefox.js
@@ -1,3 +1,5 @@
-export function isFirefox () {
-  return typeof InstallTrigger !== 'undefined' // https://stackoverflow.com/a/9851769/680742
-}
+import { thunk } from '../thunk'
+
+export const isFirefox = thunk(() => {
+  return process.browser && typeof InstallTrigger !== 'undefined' // https://stackoverflow.com/a/9851769/680742
+})
diff --git a/src/routes/_utils/userAgent/isFirefoxPre88.js b/src/routes/_utils/userAgent/isFirefoxPre88.js
new file mode 100644
index 00000000..5828e7ea
--- /dev/null
+++ b/src/routes/_utils/userAgent/isFirefoxPre88.js
@@ -0,0 +1,17 @@
+import { isFirefox } from './isFirefox'
+import { thunk } from '../thunk'
+
+export const isFirefoxPre88 = thunk(() => {
+  if (!isFirefox()) {
+    return false
+  }
+  try {
+    // https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/88#javascript
+    // https://github.com/tc39/proposal-regexp-match-indices
+    // eslint-disable-next-line no-invalid-regexp,prefer-regex-literals
+    RegExp('', 'd')
+    return false
+  } catch (e) {
+    return true
+  }
+})