From 44e3ea575eb8343d95c78042fe0404f5be613b81 Mon Sep 17 00:00:00 2001 From: Nolan Lawson Date: Tue, 19 Feb 2019 21:50:41 -0800 Subject: [PATCH] fix: remove __fakeFileInput, clean up on destroy (#1025) --- src/routes/_components/compose/ComposeToolbar.html | 12 ++++-------- tests/utils.js | 4 +++- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/src/routes/_components/compose/ComposeToolbar.html b/src/routes/_components/compose/ComposeToolbar.html index 0703db24..20b84460 100644 --- a/src/routes/_components/compose/ComposeToolbar.html +++ b/src/routes/_components/compose/ComposeToolbar.html @@ -54,14 +54,10 @@ export default { oncreate () { - // for testing - window.__fakeFileInput = (file) => { - this.onFileChange({ - target: { - files: [file] - } - }) - } + window.__composeToolbar = this // for testing + }, + ondestroy () { + window.__composeToolbar = null }, components: { IconButton, diff --git a/tests/utils.js b/tests/utils.js index 50327201..4194bc7f 100644 --- a/tests/utils.js +++ b/tests/utils.js @@ -131,7 +131,9 @@ export const uploadKittenImage = i => (exec(() => { let image = images[`kitten${i}`] let blob = blobUtils.base64StringToBlob(image.data, 'image/png') blob.name = image.name - window.__fakeFileInput(blob) + window.__composeToolbar.onFileChange({ + target: { files: [blob] } + }) }, { dependencies: { images,