From 78f44c7b5139be2273c39978146350832ae14ac5 Mon Sep 17 00:00:00 2001
From: Nolan Lawson <nolan@nolanlawson.com>
Date: Sat, 21 Apr 2018 08:45:41 -0700
Subject: [PATCH] make timeline components async (#204)

---
 routes/_components/timeline/Timeline.html | 86 ++++++++++++-----------
 routes/_utils/asyncModules.js             | 18 ++++-
 2 files changed, 61 insertions(+), 43 deletions(-)

diff --git a/routes/_components/timeline/Timeline.html b/routes/_components/timeline/Timeline.html
index 2f138d10..e87244a6 100644
--- a/routes/_components/timeline/Timeline.html
+++ b/routes/_components/timeline/Timeline.html
@@ -4,46 +4,41 @@
      on:focusWithCapture="saveFocus(event)"
      on:blurWithCapture="clearFocus(event)"
 >
-  {{#if virtual}}
-    <VirtualList component="{{VirtualListComponent}}"
-                 realm="{{$currentInstance + '/' + timeline}}"
-                 containerQuery=".container"
-                 :makeProps
-                 items="{{$timelineItemIds}}"
-                 showFooter="{{$timelineInitialized && $runningUpdate}}"
-                 footerComponent="{{LoadingFooter}}"
-                 showHeader="{{$showHeader}}"
-                 headerComponent="{{MoreHeaderVirtualWrapper}}"
-                 :headerProps
-                 on:scrollToBottom="onScrollToBottom()"
-                 on:scrollToTop="onScrollToTop()"
-                 on:scrollTopChanged="onScrollTopChanged(event)"
-                 on:initialized="initialize()"
-                 on:noNeedToScroll="onNoNeedToScroll()"
+  {{#await componentsPromise}}
+  {{then result}}
+    <:Component {result.listComponent}
+                component="{{result.listItemComponent}}"
+                realm="{{$currentInstance + '/' + timeline}}"
+                containerQuery=".container"
+                :makeProps
+                items="{{$timelineItemIds}}"
+                showFooter="{{$timelineInitialized && $runningUpdate}}"
+                footerComponent="{{LoadingFooter}}"
+                showHeader="{{$showHeader}}"
+                headerComponent="{{MoreHeaderVirtualWrapper}}"
+                :headerProps
+                :scrollToItem
+                on:scrollToBottom="onScrollToBottom()"
+                on:scrollToTop="onScrollToTop()"
+                on:scrollTopChanged="onScrollTopChanged(event)"
+                on:initialized="initialize()"
+                on:noNeedToScroll="onNoNeedToScroll()"
     />
-  {{else}}
-    <!-- if this is a status thread, it's easier to just render the
-         whole thing rather than use a virtual list -->
-    <PseudoVirtualList
-               component="{{VirtualListComponent}}"
-               realm="{{$currentInstance + '/' + timeline}}"
-               containerQuery=".container"
-               :makeProps
-               items="{{$timelineItemIds}}"
-               scrollToItem="{{scrollToItem}}"
-               on:initialized="initialize()"
-    />
-  {{/if}}
+  {{catch error}}
+    <div>Error: component failed to load! Try reloading. {{error}}</div>
+  {{/await}}
 </div>
 <script>
   import { store } from '../../_store/store'
-  import StatusVirtualListItem from './StatusVirtualListItem.html'
-  import NotificationVirtualListItem from './NotificationVirtualListItem.html'
   import Status from '../status/Status.html'
   import LoadingFooter from './LoadingFooter.html'
   import MoreHeaderVirtualWrapper from './MoreHeaderVirtualWrapper.html'
-  import VirtualList from '../virtualList/VirtualList.html'
-  import PseudoVirtualList from '../pseudoVirtualList/PseudoVirtualList.html'
+  import {
+    importVirtualList,
+    importPseudoVirtualList,
+    importStatusVirtualListItem,
+    importNotificationVirtualListItem
+  } from '../../_utils/asyncModules'
   import { timelines } from '../../_static/timelines'
   import {
     getStatus as getStatusFromDatabase,
@@ -81,8 +76,22 @@
       scrollTop: 0
     }),
     computed: {
-      VirtualListComponent: (timelineType) => {
-        return timelineType === 'notifications' ? NotificationVirtualListItem : StatusVirtualListItem
+      // For threads, it's simpler to just render all items as a pseudo-virtual list
+      // due to need to scroll to the right item and thus calculate all item heights up-front.
+      // Here we lazy-load both the virtual list component itself as well as the component
+      // it renders.
+      componentsPromise: (timelineType) => {
+        return Promise.all([
+          timelineType === 'status'
+            ? importPseudoVirtualList()
+            : importVirtualList(),
+          timelineType === 'notifications'
+            ? importNotificationVirtualListItem()
+            : importStatusVirtualListItem()
+        ]).then(results => ({
+          listComponent: results[0],
+          listItemComponent: results[1]
+        }))
       },
       makeProps: ($currentInstance, timelineType, timelineValue) => async (itemId) => {
         let res = {
@@ -120,9 +129,6 @@
       timelineValue: (timeline) => {
         return timeline.split('/').slice(-1)[0]
       },
-      // for threads, it's simpler to just render all items as a pseudo-virtual list
-      // due to need to scroll to the right item and thus calculate all item heights up-front
-      virtual: (timelineType) => timelineType !== 'status',
       // Scroll to the first item if this is a "status in own thread" timeline.
       // Don't scroll to the first item because it obscures the "back" button.
       scrollToItem: (timelineType, timelineValue, $firstTimelineItemId) => (
@@ -138,10 +144,6 @@
       }
     },
     store: () => store,
-    components: {
-      VirtualList,
-      PseudoVirtualList
-    },
     events: {
       focusWithCapture,
       blurWithCapture
diff --git a/routes/_utils/asyncModules.js b/routes/_utils/asyncModules.js
index aab1a538..6e362cfd 100644
--- a/routes/_utils/asyncModules.js
+++ b/routes/_utils/asyncModules.js
@@ -24,4 +24,20 @@ export const importWebSocketClient = () => import(
 
 export const importDialogs = () => import(
   /* webpackChunkName: 'dialogs' */ '../_components/dialog/dialogs.js'
-  )
\ No newline at end of file
+  )
+
+export const importVirtualList = () => import(
+  /* webpackChunkName: 'VirtualList.html' */ '../_components/virtualList/VirtualList.html'
+  ).then(mod => mod.default)
+
+export const importPseudoVirtualList = () => import(
+  /* webpackChunkName: 'PseudoVirtualList.html' */ '../_components/pseudoVirtualList/PseudoVirtualList.html'
+  ).then(mod => mod.default)
+
+export const importStatusVirtualListItem = () => import(
+  /* webpackChunkName: 'StatusVirtualListItem.html' */ '../_components/timeline/StatusVirtualListItem.html'
+  ).then(mod => mod.default)
+
+export const importNotificationVirtualListItem = () => import(
+  /* webpackChunkName: 'NotificationVirtualListItem.html' */ '../_components/timeline/NotificationVirtualListItem.html'
+  ).then(mod => mod.default)