From 8af2e2061fe31d18c125a1b128e142c6a71e6442 Mon Sep 17 00:00:00 2001
From: Nolan Lawson <nolan@nolanlawson.com>
Date: Thu, 8 Feb 2018 18:54:48 -0800
Subject: [PATCH] fix empty timelines

---
 routes/_actions/timeline.js                   |  2 +-
 .../pseudoVirtualList/PseudoVirtualList.html  | 32 ++++++++++---------
 routes/_components/timeline/Timeline.html     |  2 +-
 .../_components/virtualList/VirtualList.html  | 18 ++++++-----
 .../virtualList/virtualListStore.js           | 10 ++++--
 routes/_store/timelineComputations.js         |  4 +--
 6 files changed, 39 insertions(+), 29 deletions(-)

diff --git a/routes/_actions/timeline.js b/routes/_actions/timeline.js
index bd69db42..4c667a27 100644
--- a/routes/_actions/timeline.js
+++ b/routes/_actions/timeline.js
@@ -63,7 +63,7 @@ export function initializeTimeline() {
 
 export async function setupTimeline() {
   mark('setupTimeline')
-  if (!store.get('timelineItemIds').length) {
+  if (!store.get('timelineItemIds')) {
     await fetchTimelineItemsAndPossiblyFallBack()
   }
   stop('setupTimeline')
diff --git a/routes/_components/pseudoVirtualList/PseudoVirtualList.html b/routes/_components/pseudoVirtualList/PseudoVirtualList.html
index 79505ec2..4ac1ecfa 100644
--- a/routes/_components/pseudoVirtualList/PseudoVirtualList.html
+++ b/routes/_components/pseudoVirtualList/PseudoVirtualList.html
@@ -1,17 +1,19 @@
 <div class="pseudo-virtual-list {{shown ? '' : 'hidden'}}" on:initializedVisibleItems ref:node>
-  {{#each wrappedItems as wrappedItem, i @item}}
-    <PseudoVirtualListLazyItem
-      component="{{component}}"
-      index="{{i}}"
-      length="{{wrappedItems.length}}"
-      makeProps="{{makeProps}}"
-      key="{{wrappedItem.item}}"
-      intersectionObserver="{{intersectionObserver}}"
-      isIntersecting="{{isIntersecting(wrappedItem.item, $intersectionStates)}}"
-      isCached="{{isCached(wrappedItem.item, $intersectionStates)}}"
-      height="{{getHeight(wrappedItem.item, $intersectionStates)}}"
-    />
-  {{/each}}
+  {{#if wrappedItems}}
+    {{#each wrappedItems as wrappedItem, i @item}}
+      <PseudoVirtualListLazyItem
+        component="{{component}}"
+        index="{{i}}"
+        length="{{wrappedItems.length}}"
+        makeProps="{{makeProps}}"
+        key="{{wrappedItem.item}}"
+        intersectionObserver="{{intersectionObserver}}"
+        isIntersecting="{{isIntersecting(wrappedItem.item, $intersectionStates)}}"
+        isCached="{{isCached(wrappedItem.item, $intersectionStates)}}"
+        height="{{getHeight(wrappedItem.item, $intersectionStates)}}"
+      />
+    {{/each}}
+  {{/if}}
 </div>
 <style>
   .pseudo-virtual-list {
@@ -114,9 +116,9 @@
       }
     },
     computed: {
-      wrappedItems: (items) => items.map(item => ({item: item})),
+      wrappedItems: (items) => items && items.map(item => ({item: item})),
       allItemsHaveHeight: (items, $intersectionStates) => {
-        if (!items.length) {
+        if (!items) {
           return false
         }
         for (let item of items) {
diff --git a/routes/_components/timeline/Timeline.html b/routes/_components/timeline/Timeline.html
index 30c0e541..0fc2aef9 100644
--- a/routes/_components/timeline/Timeline.html
+++ b/routes/_components/timeline/Timeline.html
@@ -111,7 +111,7 @@
     },
     methods: {
       initialize() {
-        if (this.store.get('initialized') || !this.store.get('timelineItemIds') || !this.store.get('timelineItemIds').length) {
+        if (this.store.get('initialized') || !this.store.get('timelineItemIds')) {
           return
         }
         console.log('timeline initialize()')
diff --git a/routes/_components/virtualList/VirtualList.html b/routes/_components/virtualList/VirtualList.html
index 4e6dd320..66914561 100644
--- a/routes/_components/virtualList/VirtualList.html
+++ b/routes/_components/virtualList/VirtualList.html
@@ -1,13 +1,15 @@
 <!-- TODO: setting height is hacky, just make this element the scroller -->
 <div class="virtual-list {{shown ? '' : 'hidden'}}" style="height: {{$height}}px;">
-  {{#each $visibleItems as visibleItem @key}}
-    <VirtualListLazyItem :component
-                         offset="{{visibleItem.offset}}"
-                         makeProps="{{makeProps}}"
-                         key="{{visibleItem.key}}"
-                         index="{{visibleItem.index}}"
-    />
-  {{/each}}
+  {{#if $visibleItems}}
+    {{#each $visibleItems as visibleItem @key}}
+      <VirtualListLazyItem :component
+                           offset="{{visibleItem.offset}}"
+                           makeProps="{{makeProps}}"
+                           key="{{visibleItem.key}}"
+                           index="{{visibleItem.index}}"
+      />
+    {{/each}}
+  {{/if}}
   {{#if $showFooter}}
     <VirtualListFooter component="{{footerComponent}}"/>
   {{/if}}
diff --git a/routes/_components/virtualList/virtualListStore.js b/routes/_components/virtualList/virtualListStore.js
index 0d83472a..74da5e8a 100644
--- a/routes/_components/virtualList/virtualListStore.js
+++ b/routes/_components/virtualList/virtualListStore.js
@@ -11,7 +11,7 @@ class VirtualListStore extends RealmStore {
 
 const virtualListStore = new VirtualListStore()
 
-virtualListStore.computeForRealm('items', [])
+virtualListStore.computeForRealm('items', null)
 virtualListStore.computeForRealm('showFooter', false)
 virtualListStore.computeForRealm('footerHeight', 0)
 virtualListStore.computeForRealm('scrollTop', 0)
@@ -23,6 +23,9 @@ virtualListStore.compute('visibleItems',
     ['items', 'scrollTop', 'itemHeights', 'offsetHeight'],
     (items, scrollTop, itemHeights, offsetHeight) => {
   mark('compute visibleItems')
+  if (!items) {
+    return null
+  }
   let renderBuffer = VIEWPORT_RENDER_FACTOR * offsetHeight
   let visibleItems = []
   let totalOffset = 0
@@ -56,6 +59,9 @@ virtualListStore.compute('visibleItems',
 virtualListStore.compute('heightWithoutFooter',
     ['items', 'itemHeights'],
     (items, itemHeights) => {
+  if (!items) {
+    return 0
+  }
   let sum = 0
   let i = -1
   let len = items.length
@@ -77,7 +83,7 @@ virtualListStore.compute('length', ['items'], (items) => items ? items.length :
 virtualListStore.compute('allVisibleItemsHaveHeight',
     ['visibleItems', 'itemHeights'],
     (visibleItems, itemHeights) => {
-  if (!visibleItems.length) {
+  if (!visibleItems) {
     return false
   }
   for (let visibleItem of visibleItems) {
diff --git a/routes/_store/timelineComputations.js b/routes/_store/timelineComputations.js
index 58454441..7ce68c6d 100644
--- a/routes/_store/timelineComputations.js
+++ b/routes/_store/timelineComputations.js
@@ -4,8 +4,8 @@ export function timelineComputations(store) {
       return ((timelines && timelines[currentInstance]) || {})[currentTimeline] || {}
     })
 
-  store.compute('timelineItemIds', ['currentTimelineData'], (currentTimelineData) => currentTimelineData.timelineItemIds || [])
+  store.compute('timelineItemIds', ['currentTimelineData'], (currentTimelineData) => currentTimelineData.timelineItemIds)
   store.compute('runningUpdate', ['currentTimelineData'], (currentTimelineData) => currentTimelineData.runningUpdate)
   store.compute('initialized', ['currentTimelineData'], (currentTimelineData) => currentTimelineData.initialized)
-  store.compute('lastTimelineItemId', ['timelineItemIds'], (timelineItemIds) => timelineItemIds.length && timelineItemIds[timelineItemIds.length - 1])
+  store.compute('lastTimelineItemId', ['timelineItemIds'], (timelineItemIds) => timelineItemIds && timelineItemIds.length && timelineItemIds[timelineItemIds.length - 1])
 }
\ No newline at end of file