From 95c3349db74bdfea7191306a7bf14a04bbc64b19 Mon Sep 17 00:00:00 2001 From: Nolan Lawson Date: Wed, 11 Apr 2018 20:30:38 -0700 Subject: [PATCH] fix bug where favicon changes incorrectly --- routes/_utils/setFavicon.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/routes/_utils/setFavicon.js b/routes/_utils/setFavicon.js index 25fc8de7..92efd5e7 100644 --- a/routes/_utils/setFavicon.js +++ b/routes/_utils/setFavicon.js @@ -1,14 +1,17 @@ // borrowed from https://github.com/HenrikJoreteg/favicon-setter export function setFavicon (href) { let faviconId = 'theFavicon' - let link = document.createElement('link') let oldLink = document.getElementById(faviconId) + + if (oldLink.getAttribute('href') === href) { + return + } + + let link = document.createElement('link') link.id = faviconId link.rel = 'shortcut icon' link.type = 'image/png' link.href = href - if (oldLink) { - document.head.removeChild(oldLink) - } + document.head.removeChild(oldLink) document.head.appendChild(link) }