data.coop/pinafore
8
0
Fork 0
Code Issues 1 Pull requests Packages Projects Releases Wiki Activity

remove useless aria-hidden (#386)

Browse source
This commit is contained in:
Nolan Lawson 2018-06-10 19:49:39 -07:00 committed by GitHub
parent 11dcaf0cf3
commit a0d3a89180
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
routes/_components/list/ListItem.html
View file

@ -1,7 +1,5 @@
<div <div class="list-item"
id={`list-item-${key}`} id={`list-item-${key}`} >
aria-hidden="false"
>
<svelte:component this={component} <svelte:component this={component}
virtualProps={props} virtualProps={props}
virtualIndex={index} virtualIndex={index}

2
routes/_components/virtualList/VirtualListItem.html
View file

@ -1,4 +1,4 @@
<div class="virtual-list-item {shown ? 'shown' : ''}" <div class="virtual-list-item list-item {shown ? 'shown' : ''}"
aria-hidden={!shown} aria-hidden={!shown}
virtual-list-key={key} virtual-list-key={key}
ref:node ref:node

8
tests/utils.js
View file

@ -154,7 +154,7 @@ export function getNthStatus (n) {
} }
export function getNthStatusSelector (n) { export function getNthStatusSelector (n) {
return `div[aria-hidden="false"] > article[aria-posinset="${n}"]` return `.list-item > article[aria-posinset="${n}"]`
} }
export function getNthStatusContent (n) { export function getNthStatusContent (n) {
@ -173,12 +173,8 @@ export function getNthStatusAndImage (nStatus, nImage) {
return $(`${getNthStatusSelector(nStatus)} .status-media .show-image-button:nth-child(${nImage + 1}) img`) return $(`${getNthStatusSelector(nStatus)} .status-media .show-image-button:nth-child(${nImage + 1}) img`)
} }
export function getLastVisibleStatus () {
return $(`div[aria-hidden="false"] > article[aria-posinset]`).nth(-1)
}
export function getFirstVisibleStatus () { export function getFirstVisibleStatus () {
return $(`div[aria-hidden="false"] > article[aria-posinset]`).nth(0) return $(`.list-item > article[aria-posinset]`).nth(0)
} }
export function getNthReplyButton (n) { export function getNthReplyButton (n) {