From dbba271f399eff5c66c48f238bf61b3e1f6f635a Mon Sep 17 00:00:00 2001 From: Nolan Lawson Date: Mon, 30 Apr 2018 09:57:49 -0700 Subject: [PATCH] fix some svelte data warnings (#247) --- routes/_components/ExternalLink.html | 7 +++++-- routes/_components/PlayVideoIcon.html | 9 ++++++++- .../_components/community/PageListItem.html | 3 +++ .../dialog/components/ModalDialog.html | 5 ++++- .../profile/AccountProfileFollow.html | 3 +++ .../search/AccountSearchResult.html | 13 ++++++++----- routes/_components/settings/SettingsList.html | 9 ++++++++- .../settings/SettingsListItem.html | 19 +++++++++++-------- 8 files changed, 50 insertions(+), 18 deletions(-) diff --git a/routes/_components/ExternalLink.html b/routes/_components/ExternalLink.html index a2d59540..ae27cd2f 100644 --- a/routes/_components/ExternalLink.html +++ b/routes/_components/ExternalLink.html @@ -1,7 +1,7 @@ {{#if showIcon}} @@ -26,7 +26,10 @@ \ No newline at end of file diff --git a/routes/_components/PlayVideoIcon.html b/routes/_components/PlayVideoIcon.html index eaede0d7..302224c9 100644 --- a/routes/_components/PlayVideoIcon.html +++ b/routes/_components/PlayVideoIcon.html @@ -23,4 +23,11 @@ border-radius: 100%; background: var(--mask-opaque-bg); } - \ No newline at end of file + + \ No newline at end of file diff --git a/routes/_components/community/PageListItem.html b/routes/_components/community/PageListItem.html index bce969fc..6cd85457 100644 --- a/routes/_components/community/PageListItem.html +++ b/routes/_components/community/PageListItem.html @@ -69,6 +69,9 @@ export default { store: () => store, + data: () => ({ + pinnable: false + }), components: { IconButton }, diff --git a/routes/_components/dialog/components/ModalDialog.html b/routes/_components/dialog/components/ModalDialog.html index 4570dc5a..a23f1951 100644 --- a/routes/_components/dialog/components/ModalDialog.html +++ b/routes/_components/dialog/components/ModalDialog.html @@ -141,7 +141,10 @@ }, data: () => ({ // don't animate if we're showing a modal dialog on top of another modal dialog. it looks ugly - shouldAnimate: !process.browser || document.getElementsByClassName('modal-dialog').length < 2 + shouldAnimate: !process.browser || document.getElementsByClassName('modal-dialog').length < 2, + fadedIn: false, + muted: false, + className: void 0 }), computed: { backdropClass: (fadedIn, shouldAnimate) => { diff --git a/routes/_components/profile/AccountProfileFollow.html b/routes/_components/profile/AccountProfileFollow.html index f4ac266a..c7181dbc 100644 --- a/routes/_components/profile/AccountProfileFollow.html +++ b/routes/_components/profile/AccountProfileFollow.html @@ -53,6 +53,9 @@ } }, store: () => store, + data: () => ({ + overrideFollowing: void 0 + }), computed: { accountId: (account) => account.id, following: (relationship, overrideFollowing) => { diff --git a/routes/_components/search/AccountSearchResult.html b/routes/_components/search/AccountSearchResult.html index dd5a1d61..72b435cc 100644 --- a/routes/_components/search/AccountSearchResult.html +++ b/routes/_components/search/AccountSearchResult.html @@ -73,11 +73,9 @@ import IconButton from '../IconButton.html' export default { - components: { - Avatar, - SearchResult, - IconButton - }, + data: () => ({ + actions: void 0 + }), methods: { onButtonClick (event, action, accountId) { event.preventDefault() @@ -87,6 +85,11 @@ accountId }) } + }, + components: { + Avatar, + SearchResult, + IconButton } } \ No newline at end of file diff --git a/routes/_components/settings/SettingsList.html b/routes/_components/settings/SettingsList.html index 08a46258..4cca62f8 100644 --- a/routes/_components/settings/SettingsList.html +++ b/routes/_components/settings/SettingsList.html @@ -25,4 +25,11 @@ margin: 20px 0; } } - \ No newline at end of file + + \ No newline at end of file diff --git a/routes/_components/settings/SettingsListItem.html b/routes/_components/settings/SettingsListItem.html index 1493ada0..0c551570 100644 --- a/routes/_components/settings/SettingsListItem.html +++ b/routes/_components/settings/SettingsListItem.html @@ -5,15 +5,9 @@ {{/if}} - {{#if ariaLabel}} - + {{label}} - {{else}} - - {{label}} - - {{/if}} \ No newline at end of file + + \ No newline at end of file