fix: no need for double reload of SW in Chrome (#1251)

fixes #1243
This commit is contained in:
Nolan Lawson 2019-05-28 08:18:11 -07:00 committed by GitHub
parent 0de6c3a09f
commit fa2eb8fe52
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 83 additions and 12 deletions

View file

@ -36,7 +36,7 @@
methods: { methods: {
reload (event) { reload (event) {
event.preventDefault() event.preventDefault()
document.location.reload(true) location.reload()
} }
} }
} }

View file

@ -1,17 +1,81 @@
import { snackbar } from '../_components/snackbar/snackbar' import { snackbar } from '../_components/snackbar/snackbar'
function onUpdateFound (registration) { // A lot of this code is borrowed from https://github.com/GoogleChromeLabs/squoosh/blob/53b46f8/src/lib/offliner.ts
const newWorker = registration.installing // Service Workers are hard!
newWorker.addEventListener('statechange', async () => { // Tell the service worker to skip waiting
if (newWorker.state === 'installed' && navigator.serviceWorker.controller) { async function skipWaiting () {
snackbar.announce('App update available.', 'Reload', () => document.location.reload(true)) const reg = await navigator.serviceWorker.getRegistration()
if (!reg || !reg.waiting) {
return
}
reg.waiting.postMessage('skip-waiting')
}
// Wait for an installing worker
async function installingWorker (reg) {
if (reg.installing) {
return reg.installing
}
return new Promise((resolve) => {
reg.addEventListener(
'updatefound',
() => resolve(reg.installing),
{ once: true }
)
})
}
// Wait a service worker to become waiting
async function updateReady (reg) {
if (reg.waiting) {
return
}
const installing = await installingWorker(reg)
return new Promise((resolve) => {
const listener = () => {
if (installing.state === 'installed') {
installing.removeEventListener('statechange', listener)
resolve()
}
} }
installing.addEventListener('statechange', listener)
}) })
} }
if ('serviceWorker' in navigator) { (async () => {
navigator.serviceWorker.register('/service-worker.js').then(registration => { if ('serviceWorker' in navigator) {
registration.addEventListener('updatefound', () => onUpdateFound(registration)) navigator.serviceWorker.register('/service-worker.js')
})
} const hasController = !!navigator.serviceWorker.controller
navigator.serviceWorker.addEventListener('controllerchange', () => {
if (!hasController) { // first install
return
}
location.reload()
})
// If we don't have a controller, we don't need to check for updates we've just loaded from the
// network.
if (!hasController) {
return
}
const reg = await navigator.serviceWorker.getRegistration()
if (!reg) { // SW not registered yet
return
}
// Look for updates
await updateReady(reg)
// Ask the user if they want to update.
snackbar.announce('App update available.', 'Reload', () => {
// Tell the waiting worker to activate, this will change the controller and cause a reload (see
// 'controllerchange')
/* no await */ skipWaiting()
})
}
})()

View file

@ -35,7 +35,6 @@ self.addEventListener('install', event => {
caches.open(WEBPACK_ASSETS).then(cache => cache.addAll(webpackAssets)), caches.open(WEBPACK_ASSETS).then(cache => cache.addAll(webpackAssets)),
caches.open(ASSETS).then(cache => cache.addAll(assets)) caches.open(ASSETS).then(cache => cache.addAll(assets))
]) ])
self.skipWaiting()
})()) })())
}) })
@ -243,3 +242,11 @@ self.addEventListener('notificationclick', event => {
} }
})()) })())
}) })
self.addEventListener('message', (event) => {
switch (event.data) {
case 'skip-waiting':
self.skipWaiting()
break
}
})