data.coop/pinafore
8
0
Fork 0
Code Issues 1 Pull requests Packages Projects Releases Wiki Activity

fix: remove alert role from the loading indicator (#2238)

Browse source 
...so it no longer interferes with screen readers. Fixes "Loading more" alert creates extraneous verbosity for screen reader users

Fixes #2226
This commit is contained in:
Marco Zehe 2022-11-24 18:16:18 +01:00 committed by GitHub
parent 53803db5be
commit fa41fe7649
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/routes/_components/timeline/LoadingFooter.html
View file

@ -1,7 +1,6 @@
<div class="loading-footer {shown ? '' : 'hidden'}">
<div class="loading-wrapper {showLoading ? 'shown' : ''}"
aria-hidden={!showLoading}
role="alert"
>
<!-- Sapper's mousemove event listener schedules style recalculations for the loading spinner in
Chrome because it's always animating, even when hidden. So disable animations when not visible