* fix: improve autosuggest a11y
some progress on #1629
- works in Chrome on NVDA now
- works in Chrome on VoiceOver now
- shorter aria-labels, don't repeat information like "1 of 3", because
it causes the screen reader to speak too frequently, e.g. when the
selected result hasn't changed but the number of results has. Also both
NVDA and VoiceOver already speak this information
- stop doing a fancy fade animation, just show and hide the input
instantly. I worry it confuses screen readers to have the aria-hidden
attribute in there at all
- stop using a single id to identify the active descendant - give
immutable IDs and then update the aria-activedescendant instead. I think
this is what fixed Chrome.
* fix test
The `.card-title` element carries `text-overflow: ellipsis`, (and
`white-space: nowrap`), resulting in the last part of long article
titles not being visible. By adding it to the `title` attribute,
one can see the full title on hovering without having to visit the
article first.
The main concern I had was that the text is now technically
duplicated in the source code, and for short titles, also in the
UI. The primary concern there, however, was screen reader users
getting duplicate announcements. However, I believe the title
attribute is not announced by screen readers, which this (old)
article seems to confirm:
https://developer.paciellogroup.com/blog/2010/11/using-the-html-title-attribute/
That leaves the following two disadvantages:
- This doesn't solve anything for mobile users, who will still
have to follow the link to see the full title.
- Desktop users can however a (non-truncated) title to see the same
title again.
I'm not sure what changed, but #667 no longer seems to be an issue, so
it looks like we can safely remove this workaround. I even tested in a
simulator in iOS 11.4 and we don't seem to be affected anymore.
* fix: remove basic login mode for now
As described in #1552 I do not have a lot of faith in this feature, so maybe it should just be removed for now until a later release.
* fixup
* fixup
* fixup
* fix: return focus to sensitive media button
fixes#1517
* additional fix for media sensitive focus
* fix audio/video name in aria-label of button
* fix hotkeys