Commit graph

506 commits

Author SHA1 Message Date
Nolan Lawson 44c1b6feb5 fix: fix ajax code, add test, switch parser library 2020-07-04 19:34:01 -07:00
charlag 5e7c8003db fix: Fix favorites, fix #850
This commit fixes invalid assumption that all timelines are sorted by status id.
Some, like favorites or bookmarks are sorted by private server id. To correctly
paginate we must use the Link header.

To work around the issue, offline for favorites was effectively disabled.
Statuses are still inserted into the database but we can't reproduce correct
timeline order.
2020-07-04 19:34:01 -07:00
Nolan Lawson 1371175bce
feat: use emoji-picker-element, add emoji autocompletions/tooltips (#1804)
* feat: use emoji-picker-element, add emoji autocompletions/tooltips

* fix: fix lint bug

* test: fix emoji in chrome on linux in travis

* test: try bionic in travis

* chore: try to fix travis

* chore: try to fix travis

* fix: filter unsupported emoji

* chore: try to fix travis

* chore: try to fix travis

* chore: try to fix travis

* chore: try to fix travis

* Revert "chore: try to fix travis"

This reverts commit 3cd2d94469b2f1a20c847c2a69e088d7c8d1efdd.

* fix: fix emoji autosuggest

* test: fix test
2020-06-28 23:12:14 -07:00
Nolan Lawson 85ce93177b
fix: add apple-mobile-web-app-capable (#1803)
Fixes #1802
2020-06-25 19:09:27 -07:00
Nolan Lawson ec8e872f8d
fix: better error message for invalid instances (#1793) 2020-05-30 11:05:13 -07:00
Nolan Lawson ceff1f1f8f
fix: tweak indicator design again (#1789) 2020-05-23 09:28:23 -07:00
Nolan Lawson 1fc14107c8
fix: tweak nav indicator so it's a bit more prominent (#1788) 2020-05-20 21:10:56 -07:00
Nolan Lawson bedb636182
fix: css cleanup of nav-related variables (#1786)
* fix: css cleanup of nav-related variables

* changed my mind on this margin
2020-05-20 07:07:47 -07:00
Nolan Lawson f080148aad
perf: lazy-lazy-load the :focus-visible polyfill (#1785) 2020-05-19 07:52:28 -07:00
Nolan Lawson a790004be7
fix: Revert "perf: always load focus-visible polyfill (#1780)" (#1784)
This reverts commit c98b198e60.
2020-05-18 22:19:33 -07:00
Nolan Lawson c98b198e60
perf: always load focus-visible polyfill (#1780) 2020-05-18 21:11:13 -07:00
Nolan Lawson ea1315858d
perf: use OffscreenCanvas in Chrome 82+ (#1779) 2020-05-18 20:00:02 -07:00
Nolan Lawson beade4aec3
fix: use attr rather than class for focus-visible polyfill (#1778)
fixes #1777
2020-05-16 14:25:12 -07:00
Nolan Lawson cc62000b21
feat: use :focus-visible, add setting to enable/disable it (#1775)
* feat: use :focus-visible, add setting to enable it

* add the ids back

* css cleanup
2020-05-16 13:36:08 -07:00
Nolan Lawson 836b0e341f
perf: lazy-load the thread context (#1774)
* perf: lazy-load the thread context

fixes #898

* more tests

* test: more tests

* simplify implementation
2020-05-16 13:35:57 -07:00
Nolan Lawson c610a259d5
fix: ListItem should have proper fade animations (#1771) 2020-05-14 21:22:33 -07:00
Nolan Lawson dacd9dcc5b
fix: fix polls with content warnings (#1768)
* fix: fix polls with content warnings

fixes #1766

* fixup
2020-05-10 19:41:55 -07:00
Nolan Lawson 5c4b44e3dd
fix: fix potential null exception (#1765) 2020-05-03 10:45:32 -07:00
Nolan Lawson 4b4cee3662
fix: fix delete-and-redraft in Firefox Android (#1762)
fixes #1681
2020-05-03 10:45:11 -07:00
Nolan Lawson 0c300f8e70
fix: change all opacity animation timings to 0.2s (#1753) 2020-04-30 21:54:07 -07:00
Nolan Lawson 4ad7de8e8d
fix: fix rendering order bug in Firefox for Android (#1752) 2020-04-29 22:00:20 -07:00
Nolan Lawson 0ce47f0379
fix: fix fade animations on slow devices (#1751)
I noticed that, on 6x CPU throttling in Chrome, the status fade-in animations were not consistent when switching columns. This fixes that using rAF.
2020-04-28 17:48:31 -07:00
Nolan Lawson 5f6c5d89d1
fix: only avoid scrollbar motion for prefers-reduced-motion (#1750)
After thinking about it, I do not believe the scrollbar is that distracting. But for prefers-reduced-motion we should be careful about the scrollbar growing so quickly.
2020-04-28 17:48:25 -07:00
Nolan Lawson e1532ed9d1
perf: calculate plaintext from HTML content in advance in rIC (#1748)
On the Nexus 5 especially, this ensures we no longer have nearly so many
"long tasks" (i.e. responsiveness is better). It moves html-to-txt
calculation to the same step as blurhash decoding, where it can be done
in requestIdleCallback (heck, maybe someday it could just be done in a
worker thread as well).
2020-04-26 18:30:49 -07:00
Nolan Lawson ae3bd2bda2
perf: make timeline rendering less janky (#1747)
* perf: make timeline rendering less janky

1. Ensures all statuses are rendered from top to bottom (no more shuffling-card-effect rendering)
2. Wraps all individual status renders in their own requestIdleCallback to improve input responsiveness especially only slow devices like Nexus 5.

* fix focus restoration

* only do rIC on mobile
2020-04-26 16:54:00 -07:00
Nolan Lawson 06a403df28
fix: left/right hotkey works on all settings page (#1745)
fixes #1744
2020-04-25 19:35:14 -07:00
Nolan Lawson a4a9cb7962
fix: fix nav links in Voice Control on iOS (#1746)
fixes #1735
2020-04-25 19:35:03 -07:00
Nolan Lawson 1f0d67fcc4
feat: aria-labels and buttons contain more media info (#1743)
* feat: aria-labels and buttons contain more media info

fixes #1733

* fix lint
2020-04-25 19:03:39 -07:00
Nolan Lawson 912dda8778
fix: fix svelte dev warning about pinIndex (#1729) 2020-03-08 12:01:23 -07:00
Nolan Lawson ec627f9732
fix: fix newlines in poll option titles (#1717) 2020-03-01 13:54:08 -08:00
Nolan Lawson c83c12e617
fix: remove safari-specific service worker code (#1712)
fixes #1595
2020-02-26 07:38:55 -08:00
Milan d16ccd5d5f
fix: change pitch black theme (#1702)
On AMOLED displays the pitch black theme was unsatisfying. I have
changed the theme to use #000 as main theme color, which completely
stops the OLED pixels from emitting light, thus saving energy and
on some devices making the background indistinguishable from the screen
border.
2020-02-26 07:03:15 -08:00
Nolan Lawson 21a300bd4c
fix: remove intrinsicsize in favor of width/height (#1690) 2019-12-24 10:47:27 -08:00
Nolan Lawson 78014a7f33
fix: remove remount (#1688)
* fix: remove remount

* fixup
2019-12-23 18:10:03 -08:00
Nolan Lawson 3129ae7344
fix: remove deprecated scrollbar styles (#1687) 2019-12-23 11:53:55 -08:00
Nolan Lawson 22fd567eb1
fix: update emoji-mart, add dark mode and custom categories (#1686) 2019-12-23 11:53:44 -08:00
Isabelle Knott 46ff09b072 fix: Wellness page had the wrong breadcrumb (#1684) 2019-12-23 11:53:35 -08:00
Nolan Lawson 56ab988d1a
fix: fix search width on narrow sizes (#1678) 2019-12-15 09:58:43 -08:00
Nolan Lawson 79537fb8cd
fix: handle pleroma ping messages (#1676)
* fix: handle pleroma ping messages

fixes #1673

* refactor safeParse
2019-12-15 09:58:00 -08:00
Nolan Lawson 1d3859a4e2
fix: fix duplicates in threads (#1672)
fixes #943
2019-12-14 12:04:36 -08:00
Nolan Lawson aa662682f3
fix: restore focus on community page (#1669) 2019-12-13 08:31:05 -08:00
Nolan Lawson 47ade12167
refactor: refactor timeline filtering logic (#1667) 2019-12-08 18:03:39 -08:00
Nolan Lawson 4f9fb5f253
fix: settings pages preserve focus (#1666)
fixes #1658
2019-12-08 18:03:26 -08:00
Sorin Davidoi 5f51bd5aad fix(service-worker): Make API call to the right endpoint (#1664)
Closes #1663.
2019-12-08 09:56:23 -08:00
Nolan Lawson c071ac1174
refactor: refactor focus management (#1662) 2019-11-30 17:43:31 -08:00
Timo Tijhof 9ce900c767 fix: Avoid autocapitalize keyboard for instance name (#1653)
* fix: Avoid autocapitalize keyboard for instance name

On iOS Safari (possibly other browsers as well), auto-capitalization is enabled
even for input fields with inputmode=url.

In my testing, the inputmode attribute is working supported and working (in so
far that iOS does consider it and and provides me a keyboard optimised for URL
inputs, with quick buttons for slash and .com etc).

The autocapitalize is supported on Safari, per:
https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariHTMLRef/Articles/Attributes.html#//apple_ref/doc/uid/TP40008058-autocapitalize

Fixes https://github.com/nolanlawson/pinafore/issues/1652.

* fix: Avoid spell check on Instance name field

Checking of spelling and grammar and automatic corrections thereof
are likely unwanted when entering the instance domain/URL.
2019-11-23 23:42:38 -08:00
Nolan Lawson cbbf5abd7a
test: test for DOM listener memory leaks (#1654)
* test: test for DOM listener memory leaks

* fix whitespace change, unintended
2019-11-23 23:42:22 -08:00
Nolan Lawson 95ef639b21
test: add basic memory leak test (#1650)
* test: add basic memory leak test

* try to fix test
2019-11-23 19:11:15 -08:00
Nolan Lawson fec0c282c9
fix: make autosuggest list appear over modal dialog (#1649)
fixes #1645
2019-11-23 13:21:21 -08:00
Nolan Lawson 4221ce1c72
fix: media nav buttons should be a list (#1648)
More work on #1633, improves accessibility of the media nav buttons by cleaning up the list and labels a bit.
2019-11-23 11:25:42 -08:00
Nolan Lawson d03d223fd9
fix: remove aria-pressed entirely (#1647)
More progress on #1633
2019-11-23 11:25:36 -08:00
Nolan Lawson 1b95499008
fix: use radio buttons for pinning timelines (#1644)
* fix: use radio buttons for pinning timelines

more work on #1633

* cleanup styles
2019-11-17 23:02:05 -05:00
Nolan Lawson 568a3f51fe
fix: convert many toggle buttons into regular buttons (#1643)
work on #1633
2019-11-17 21:23:32 -05:00
Nolan Lawson 4903f2effa
perf: avoid aria-hidden="false" (#1640) 2019-11-17 20:51:44 -05:00
Nolan Lawson 92d77c34be
fix: use radiogroup for instance switcher (#1634)
* fix: use radiogroup for instance switcher

progress on #1633

* fixup

* add unique id
2019-11-17 20:51:28 -05:00
Nolan Lawson 63c9f8dc32
fix: fix autocomplete in voiceover+safari (#1632)
* fix: fix autocomplete in voiceover+safari

fixes #1629

* fix test

* fix test
2019-11-09 23:01:32 -05:00
Nolan Lawson 07facea505
fix: improve autosuggest a11y (#1630)
* fix: improve autosuggest a11y

some progress on #1629

- works in Chrome on NVDA now
- works in Chrome on VoiceOver now
- shorter aria-labels, don't repeat information like "1 of 3", because
it causes the screen reader to speak too frequently, e.g. when the
selected result hasn't changed but the number of results has. Also both
NVDA and VoiceOver already speak this information
- stop doing a fancy fade animation, just show and hide the input
instantly. I worry it confuses screen readers to have the aria-hidden
attribute in there at all
- stop using a single id to identify the active descendant - give
immutable IDs and then update the aria-activedescendant instead. I think
this is what fixed Chrome.

* fix test
2019-11-09 20:38:29 -05:00
Nolan Lawson c5a005186c
fix: fix more html entities in card titles (#1628) 2019-11-09 17:25:39 -05:00
Nolan Lawson edc014cf8c
fix: more consistent toggle button aria-label/title (#1626)
* fix: more consistent toggle button aria-label/title

fixes #1624

* fixup

* fix test
2019-11-09 17:25:26 -05:00
Nolan Lawson 4ecb04588c
fix: fix custom emoji in polls (#1619)
fixes #1617
2019-10-31 23:01:35 -07:00
Nolan Lawson ee492c1765
fix: change "add instance" to "log in" when not logged in (#1614) 2019-10-31 06:45:36 -07:00
Nolan Lawson b8d9c29bac
perf: move async modules to individual files (#1611) 2019-10-29 18:58:49 -07:00
Nolan Lawson bb85bcb32b
fix: switch to arrow-key-navigation library (#1607)
For left/right arrow key navigation, switch to a small library I made to
handle this. Also make it load asynchronously, because why not.
2019-10-28 08:16:51 -07:00
Nolan Lawson e569c757d1
fix: fix kaios left-right navigation on inputs (#1606) 2019-10-27 11:12:02 -07:00
Nolan Lawson cf2a6022dd
fix: fix regenerator error in legacy mode (#1605) 2019-10-27 11:11:57 -07:00
Cătălin Mariș f17386c8cb perf: Further optimize used SVGs (#1603) 2019-10-27 10:08:03 -07:00
Nolan Lawson 9f12d1ca07
fix: use small modules for userAgent.js instead of terser magic (#1602) 2019-10-24 20:37:23 -07:00
Nolan Lawson 7c04b86405
fix: use smooth scroll polyfill in Chrome for scroll-to-top (#1601)
* fix: use smooth scroll polyfill in Chrome for scroll-to-top

* rename thunk to __thunk__ for safety
2019-10-24 19:03:10 -07:00
Nolan Lawson 0194a07823
perf: use raw html for some external links (#1600) 2019-10-24 19:03:03 -07:00
Vincent 852a8582fb fix: Add the non-truncated text in the title attribute (#1598)
The `.card-title` element carries `text-overflow: ellipsis`, (and
`white-space: nowrap`), resulting in the last part of long article
titles not being visible. By adding it to the `title` attribute,
one can see the full title on hovering without having to visit the
article first.

The main concern I had was that the text is now technically
duplicated in the source code, and for short titles, also in the
UI. The primary concern there, however, was screen reader users
getting duplicate announcements. However, I believe the title
attribute is not announced by screen readers, which this (old)
article seems to confirm:
https://developer.paciellogroup.com/blog/2010/11/using-the-html-title-attribute/

That leaves the following two disadvantages:
- This doesn't solve anything for mobile users, who will still
  have to follow the link to see the full title.
- Desktop users can however a (non-truncated) title to see the same
  title again.
2019-10-23 21:54:57 -07:00
Nolan Lawson c174c19ddd
fix: fix tesseract.js progress bar (#1599)
* fix: fix tesseract.js progress bar

* fixup
2019-10-23 18:07:24 -07:00
Nolan Lawson 2a248cb482
fix: update tesseract to the latest version (#1596)
* chore: update tesseract to the latest version

* fix stuff

* fix delay

* fix caching, fixes #1457
2019-10-22 20:45:30 -07:00
Nolan Lawson 3bc6e3d777
fix: only do range request override in Safari (#1594)
should fix #1590
2019-10-18 19:03:04 -07:00
Nolan Lawson 01b0c43f0d
fix: remove type="*" from videos (#1593) 2019-10-17 18:27:30 -07:00
Nolan Lawson c13b2df6c5
fix: fix duplicate accounts in replies in Pleroma (#1592)
fixes #1591
2019-10-16 18:09:19 -07:00
Nolan Lawson d663dd7fe8
fix: fix wasted space in options dialog (#1585)
fixes #1487
2019-10-15 19:35:00 -07:00
Nolan Lawson 67b71231d3
fix: use short usernames in options dialog (#1576) 2019-10-15 07:56:39 -07:00
Nolan Lawson ac4d512363
fix: do not cache license files in service worker (#1575) 2019-10-15 06:52:27 -07:00
Nolan Lawson afb06d988e
perf: use webpack contenthash for better caching (#1573) 2019-10-14 20:00:57 -07:00
Nolan Lawson 2bafaa455e
fix: tweak autosuggest error logging and resetting (#1572) 2019-10-13 13:53:48 -07:00
Nolan Lawson d580a9b7e8
fix: do not prefer lowercase for hashtags in search (#1571) 2019-10-13 10:49:39 -07:00
Nolan Lawson 3209d934e8
fix: tweak autocomplete behavior (#1570)
tweak the hashtag sort algorithm
fix issue where wrong results shown when offline or on slow network
refactor RequestThrottler
2019-10-13 08:08:06 -07:00
Nolan Lawson 89265f709e
fix: combine request throttling logic (#1568) 2019-10-12 21:08:08 -07:00
Nolan Lawson 8b3842f15a
feat: add hashtag autocomplete (#1567)
* feat: add hashtag autocomplete

fixes #1209

* add test and tweak aria label and styles

* do not prefer lowercase

* Change text
2019-10-12 18:06:04 -07:00
Nolan Lawson 138fe83082
fix: deduplicate settings styles (#1564) 2019-10-10 07:06:04 -07:00
Nolan Lawson 0b5adfa2c9
fix: fix fade in animation on compose button (#1557) 2019-10-08 05:59:50 -07:00
Nolan Lawson 8c5d6fe667
fix: remove iOS sticky workaround (#1556)
I'm not sure what changed, but #667 no longer seems to be an issue, so
it looks like we can safely remove this workaround. I even tested in a
simulator in iOS 11.4 and we don't seem to be affected anymore.
2019-10-08 05:59:45 -07:00
sgenoud 3de7a5ba9a fix: Return a synthetic response for range requests (#1555)
Fixes #1547
2019-10-07 08:36:05 -07:00
Nolan Lawson 8f044e19c8
fix: remove basic login mode for now (#1554)
* fix: remove basic login mode for now

As described in #1552 I do not have a lot of faith in this feature, so maybe it should just be removed for now until a later release.

* fixup

* fixup

* fixup
2019-10-07 07:15:19 -07:00
Nolan Lawson d53430fee5
fix: fix uploading photos on iOS 13 (#1550)
fixes #1546
2019-10-07 07:15:05 -07:00
Nolan Lawson 5167e04417
fix: small kaios tweak for infinite scroll (#1549) 2019-10-07 07:14:58 -07:00
Nolan Lawson 56ba259ccf
fix: fix basic login - clear store on log out (#1545)
fixes #1544
2019-09-26 09:07:49 -07:00
Nolan Lawson 4ddf47f3da
feat: implement basic login mode (#1543)
fixes #1542
2019-09-26 05:28:52 -07:00
Nolan Lawson 2ada968439
fix: fix search on Mastodon v3 (#1541)
fixes #1539
2019-09-26 05:24:20 -07:00
Alex Berg 5e150b31df fix: Add "unfavorite/unboost" label (#1540)
* Add "unfavorite" label.

* fixup, also fix Boost/Unboost

* fix test
2019-09-26 05:24:05 -07:00
Nolan Lawson 038dc27163
perf: lazy-load computations (#1538)
* perf: lazy-load computations (experimental)

* fix lint

* add marks

* fixup

* lazy-load mixins too

* add missing files

* fix tests
2019-09-26 05:23:36 -07:00
Nolan Lawson 8fbf38e974
fix: fix video on iOS Safari (#1537)
* fix: fix video on iOS Safari

* add another missing type
2019-09-24 22:32:27 -07:00
Nolan Lawson 2c6a8468ea
fix: apply focus-fix to account profile name (#1536) 2019-09-24 22:32:06 -07:00
Nolan Lawson ea4c1ad819
fix: return focus to sensitive media button (#1535)
* fix: return focus to sensitive media button

fixes #1517

* additional fix for media sensitive focus

* fix audio/video name in aria-label of button

* fix hotkeys
2019-09-24 22:31:56 -07:00
Nolan Lawson af27c8b26b
fix: remove relative timestamp from tab focus order (#1534)
fixes #1533
2019-09-24 22:30:26 -07:00