emelie/tidy-html5
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Ensure that TidyQuiet silences everything that it currently quiets, plus

Browse source 
`TidyConfig` and `TidyInfo` messages. This causes a single regression by hiding
`TidyInfo`; will publish PR in testing repo.
This commit is contained in:
Jim Derry 2017-10-20 08:52:37 -04:00
parent 4b1c048ee5
commit c12e2b2149
2 changed files with 22 additions and 40 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/language_en.h
View file

@ -1043,8 +1043,8 @@ static languageDefinition language_en = { whichPluralForm_en, {
- The strings "Tidy" and "HTML Tidy" are the program name and must not - The strings "Tidy" and "HTML Tidy" are the program name and must not
be translated. */ be translated. */
TidyQuiet, 0, TidyQuiet, 0,
"This option specifies if Tidy should output the summary of the numbers " "When enabled, this option limits Tidy's non-document output to report "
"of errors and warnings, or the welcome or informational messages. " "only document warnings and errors. "
}, },
{/* Important notes for translators: {/* Important notes for translators:
- Use only <code></code>, <var></var>, <em></em>, <strong></strong>, and - Use only <code></code>, <var></var>, <em></em>, <strong></strong>, and

58
src/message.c
View file

@ -161,53 +161,35 @@ static void messageOut( TidyMessageImpl *message )
{ {
go = go & ( doc->errors < cfg(doc, TidyShowErrors) ); go = go & ( doc->errors < cfg(doc, TidyShowErrors) );
} }
/* Check for conditions to suppress TidyInfo. */
if ( message->level == TidyInfo )
{
go = go & (cfgBool(doc, TidyShowInfo) == yes);
/* Temporary; we currently let TidyQuiet hide these: */ /* Let TidyQuiet silence a lot of things. */
switch ( message->code ) if ( cfgBool( doc, TidyQuiet ) == yes )
{ {
case STRING_DOCTYPE_GIVEN: go = go && message->code != STRING_DOCTYPE_GIVEN;
case STRING_CONTENT_LOOKS: go = go && message->code != STRING_CONTENT_LOOKS;
case STRING_NO_SYSID: go = go && message->code != STRING_NO_SYSID;
go = go && !cfgBool(doc, TidyQuiet); go = go && message->level != TidyDialogueInfo;
break; go = go && message->level != TidyConfig;
default: go = go && message->level != TidyInfo;
break; go = go && !(message->level >= TidyDialogueSummary &&
} message->code != STRING_NEEDS_INTERVENTION);
} }
/* Suppress TidyWarning on Reports if applicable. */ /* Let !TidyShowInfo silence some things. */
if ( message->level == TidyWarning ) if ( cfgBool( doc, TidyShowInfo ) == no )
{ {
go = go & (cfgBool(doc, TidyShowWarnings) == yes); go = go && message->level != TidyInfo;
}
/* Check for conditions to suppress TidyDialogueInfo */
if ( message->level == TidyDialogueInfo )
{
/* Temporary; TidyShowInfo shouldn't affect TidyDialogueInfo, but /* Temporary; TidyShowInfo shouldn't affect TidyDialogueInfo, but
right now such messages are hidden until we granularize the right now such messages are hidden until we granularize the
output controls. */ output controls. */
go = go & (cfgBool(doc, TidyShowInfo) == yes); go = go && message->level != TidyDialogueInfo;
go = go | (cfgBool(doc, TidyQuiet) == yes);
} }
/* Check for conditions to suppress TidyDialogueSummary */ /* Let !TidyShowWarnings silence some things. */
/* Temporary; TidyQuiet shouldn't hide this type of message. */ if ( cfgBool( doc, TidyShowWarnings ) == no )
if ( message->level == TidyDialogueSummary && message->code != STRING_NEEDS_INTERVENTION )
{ {
go = go & !cfgBool(doc, TidyQuiet); go = go && message->level != TidyWarning;
}
/* If we're TidyQuiet and handling any type of dialogue above summaries,
then suppress. */
if ( message->level > TidyDialogueSummary )
{
go = go & !cfgBool(doc, TidyQuiet);
} }
/* Output the message if applicable. */ /* Output the message if applicable. */