emelie/tidy-html5
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Issue #217 - avoid len going negative, ever...

Browse source
This commit is contained in:
Geoff McLane 2015-06-03 20:26:03 +02:00
parent 0fb7ccdfc6
commit c18f27a587
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/lexer.c
View file

@ -48,6 +48,7 @@
#endif
#if !defined(NDEBUG) && defined(_MSC_VER)
/* #define DEBUG_ALLOCATION special EXTRA allocation debug information - VERY NOISY */
static void check_me(char *name);
static Bool show_attrs = yes;
#define MX_TXT 5
@ -3739,16 +3740,17 @@ static tmbstr ParseValue( TidyDocImpl* doc, ctmbstr name,
/* and prompts attributes unless --literal-attributes is set to yes */
/* #994841 - Whitespace is removed from value attributes */
if (munge &&
/* Issue #217 - Also only if/while (len > 0) - MUST NEVER GO NEGATIVE! */
if ((len > 0) && munge &&
TY_(tmbstrcasecmp)(name, "alt") &&
TY_(tmbstrcasecmp)(name, "title") &&
TY_(tmbstrcasecmp)(name, "value") &&
TY_(tmbstrcasecmp)(name, "prompt"))
{
while (TY_(IsWhite)(lexer->lexbuf[start+len-1]))
while (TY_(IsWhite)(lexer->lexbuf[start+len-1]) && (len > 0))
--len;
while (TY_(IsWhite)(lexer->lexbuf[start]) && start < len)
while (TY_(IsWhite)(lexer->lexbuf[start]) && (start < len) && (len > 0))
{
++start;
--len;