emelie/tidy-html5
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Bad, repeated node iteration! closes #459

Browse source
This commit is contained in:
Geoff McLane 2016-10-30 23:37:31 +01:00
parent 92a872251b
commit fd0ccb2bbf
2 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/parser.c
View file

@ -3851,7 +3851,15 @@ Bool TY_(FindNodeWithId)( Node *node, TidyTagId tid )
{
if (TagIsId(node,tid))
return yes;
for (content = node->content; content; content = content->content)
/*\
* Issue #459 - Under certain circumstances, with many node this use of
* 'for (content = node->content; content; content = content->content)'
* would produce a **forever** circle, or at least a very extended loop...
* It is sufficient to test the content, if it exists,
* to quickly iterate all nodes. Now all nodes are tested only once.
\*/
content = node->content;
if (content)
{
if (TY_(FindNodeWithId)(content,tid))
return yes;

4
version.txt
View file

@ -1,2 +1,2 @@
5.3.11
2016.09.11
5.3.12
2016.10.14