From 015f1467928163ecbde4b9ca847f917ef9db0d1c Mon Sep 17 00:00:00 2001
From: Vincent Prouillet <vincent@wearewizards.io>
Date: Wed, 5 Jul 2017 12:18:37 +0900
Subject: [PATCH] Put back a limit on rss feed number of pages

---
 CHANGELOG.md                    | 2 +-
 components/config/src/lib.rs    | 2 +-
 components/site/benches/site.rs | 9 +++++++++
 components/site/src/lib.rs      | 5 ++++-
 4 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5047dec9..381853be 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,7 +6,7 @@
 - Add weight sorting
 - Remove `section` from the `page` rendering context: this is too expensive. Use
 the global function `get_section` if you need to get it
-- Fix next/previous in pagination being incorrect
+- Put back a 20 page limit on rss feed by default (configurable)
 
 ## 0.0.7 (2017-06-19)
 
diff --git a/components/config/src/lib.rs b/components/config/src/lib.rs
index b6198852..37b522c4 100644
--- a/components/config/src/lib.rs
+++ b/components/config/src/lib.rs
@@ -68,7 +68,7 @@ impl Config {
         set_default!(config.language_code, "en".to_string());
         set_default!(config.highlight_code, false);
         set_default!(config.generate_rss, false);
-        set_default!(config.rss_limit, <usize>::max_value());
+        set_default!(config.rss_limit, 20);
         set_default!(config.generate_tags_pages, false);
         set_default!(config.generate_categories_pages, false);
         set_default!(config.insert_anchor_links, false);
diff --git a/components/site/benches/site.rs b/components/site/benches/site.rs
index 3740fe50..0088e030 100644
--- a/components/site/benches/site.rs
+++ b/components/site/benches/site.rs
@@ -35,3 +35,12 @@ fn bench_render_sitemap(b: &mut test::Bencher) {
     site.set_output_path(&public);
     b.iter(|| site.render_sitemap().unwrap());
 }
+
+#[bench]
+fn bench_render_rss_feed(b: &mut test::Bencher) {
+    let mut site = setup_site("huge-blog");
+    let tmp_dir = TempDir::new("benches").expect("create temp dir");
+    let public = &tmp_dir.path().join("public");
+    site.set_output_path(&public);
+    b.iter(|| site.render_rss_feed().unwrap());
+}
diff --git a/components/site/src/lib.rs b/components/site/src/lib.rs
index 285d2983..631c7b30 100644
--- a/components/site/src/lib.rs
+++ b/components/site/src/lib.rs
@@ -39,6 +39,8 @@ use pagination::Paginator;
 use rayon::prelude::*;
 
 
+/// The sitemap only needs links and potentially date so we trim down
+/// all pages to only that
 #[derive(Debug, Serialize)]
 struct SitemapEntry {
     permalink: String,
@@ -566,8 +568,9 @@ impl Site {
         if pages.is_empty() {
             return Ok(());
         }
-        context.add("last_build_date", &pages[0].meta.date);
+
         let (sorted_pages, _) = sort_pages(pages, SortBy::Date);
+        context.add("last_build_date", &sorted_pages[0].meta.date);
         context.add("pages", &sorted_pages);
         context.add("config", &self.config);