From 94d65554df6f7f9f76b54fcf275d2f75dc73d416 Mon Sep 17 00:00:00 2001 From: Mark Nellemann Date: Thu, 10 Aug 2023 14:31:06 +0200 Subject: [PATCH] Remove unchecked warnings. --- .../biz/nellemann/mdexpl/NetworkServiceCell.java | 2 -- .../nellemann/mdexpl/service/DiscoveryService.java | 14 ++++++++++++++ .../biz/nellemann/mdexpl/view/MainPresenter.java | 5 ++--- 3 files changed, 16 insertions(+), 5 deletions(-) diff --git a/src/main/java/biz/nellemann/mdexpl/NetworkServiceCell.java b/src/main/java/biz/nellemann/mdexpl/NetworkServiceCell.java index 0276316..9458a78 100644 --- a/src/main/java/biz/nellemann/mdexpl/NetworkServiceCell.java +++ b/src/main/java/biz/nellemann/mdexpl/NetworkServiceCell.java @@ -32,10 +32,8 @@ public class NetworkServiceCell extends CharmListCell { icon.setWidth(25); tile.setPrimaryGraphic(icon); tile.setOnMouseClicked(e -> { - System.out.println("Selected -> " + itemProperty().get().getName() ); clipboardContent.putString(itemProperty().get().getUrl()); clipboard.setContent(clipboardContent); - // TODO: Copy to iOS / Android clipboard }); setText(null); } diff --git a/src/main/java/biz/nellemann/mdexpl/service/DiscoveryService.java b/src/main/java/biz/nellemann/mdexpl/service/DiscoveryService.java index e17da8a..d9d0cfb 100644 --- a/src/main/java/biz/nellemann/mdexpl/service/DiscoveryService.java +++ b/src/main/java/biz/nellemann/mdexpl/service/DiscoveryService.java @@ -8,6 +8,7 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; import javax.annotation.PostConstruct; +import javax.annotation.PreDestroy; import javax.inject.Singleton; import javax.jmdns.JmDNS; import java.io.IOException; @@ -78,6 +79,18 @@ public class DiscoveryService { } + @PreDestroy + public void destroy() { + if(jmdns != null) { + try { + jmdns.close(); + } catch (IOException e) { + log.error("destroy() - {}", e.getMessage()); + } + } + } + + public void setObservableList(ObservableList list) { this.observableList = list; services.forEach((item, color) -> { @@ -87,4 +100,5 @@ public class DiscoveryService { }); } + } diff --git a/src/main/java/biz/nellemann/mdexpl/view/MainPresenter.java b/src/main/java/biz/nellemann/mdexpl/view/MainPresenter.java index 19fb28f..7c8d6a8 100644 --- a/src/main/java/biz/nellemann/mdexpl/view/MainPresenter.java +++ b/src/main/java/biz/nellemann/mdexpl/view/MainPresenter.java @@ -39,9 +39,9 @@ public class MainPresenter { private ResourceBundle resources; @FXML - private CharmListView charmListView; + private CharmListView charmListView; - private ObservableList devicesList = FXCollections.observableArrayList(); + private final ObservableList devicesList = FXCollections.observableArrayList(); @FXML @@ -62,7 +62,6 @@ public class MainPresenter { }); discoveryService.setObservableList(devicesList); - charmListView.setItems(devicesList); charmListView.setCellFactory(p -> new NetworkServiceCell()); }