From 9c783336e6c96b7a52e3b2d82a147b1d2e19181f Mon Sep 17 00:00:00 2001
From: Christoffer <christoffer@netravnen.de>
Date: Sat, 5 Jan 2019 22:55:25 +0000
Subject: [PATCH] lib: add constants.php to hold ALL constants. Instead of
 stuffing contants into define.php

---
 lib/constants.php | 13 +++++++++++++
 lib/define.php    |  3 ---
 rfc8416.php       |  5 +++--
 roagen.php        |  6 ++++--
 4 files changed, 20 insertions(+), 7 deletions(-)
 create mode 100644 lib/constants.php

diff --git a/lib/constants.php b/lib/constants.php
new file mode 100644
index 0000000..8707981
--- /dev/null
+++ b/lib/constants.php
@@ -0,0 +1,13 @@
+<?php
+/*
+  File ONLY used to define contstants with 'define' php function.
+*/
+
+
+define ("MAX_LEN_IPV4", 28);
+define ("MAX_LEN_IPV6", 64);
+
+define ("MAX_LEN_IPV4_AS0", 32);
+define ("MAX_LEN_IPV6_AS0", 128);
+
+?>
diff --git a/lib/define.php b/lib/define.php
index 8c71b21..0db6ddb 100644
--- a/lib/define.php
+++ b/lib/define.php
@@ -9,8 +9,5 @@ $files4 = scandir ("../registry/data/route/");
 // Define array() we are gonna store data inside.
 $roas = array();
 
-define ("MAX_LEN_IPV4", 28);
-define ("MAX_LEN_IPV6", 64);
-
 $web_registry_url = 'https://git.dn42.us/dn42/registry/src/master';
 ?>
diff --git a/rfc8416.php b/rfc8416.php
index 47bbc93..f11c447 100755
--- a/rfc8416.php
+++ b/rfc8416.php
@@ -1,6 +1,7 @@
 <?php
 
 // Load lib files.
+require ("lib/constants.php");
 require ("lib/define.php");
 require ("lib/functions.php");
 
@@ -111,7 +112,7 @@ foreach ($raw_array as $sub_array)
     
     $roas["locallyAddedAssertions"]["prefixAssertions"][$k]["asn"] = trim ($_asn[0], "AS");
     $roas["locallyAddedAssertions"]["prefixAssertions"][$k]["prefix"] = $_prefix;
-    $roas["locallyAddedAssertions"]["prefixAssertions"][$k]["maxPrefixLength"] = ($_asn[0] != "AS0" ? $_maxlength : 128);
+    $roas["locallyAddedAssertions"]["prefixAssertions"][$k]["maxPrefixLength"] = ($_asn[0] != "AS0" ? $_maxlength : MAX_LEN_IPV6_AS0);
     $roas["locallyAddedAssertions"]["prefixAssertions"][$k]["comment"] = "$web_registry_url/data/inet6num/$prefix[1]_$prefix[2]";
     $roas["locallyAddedAssertions"]["prefixAssertions"][$k]["source"] = "$_ta";
     $roas["locallyAddedAssertions"]["prefixAssertions"][$k]["mnt-by"] = "$_mnt";
@@ -212,7 +213,7 @@ foreach ($raw_array as $sub_array)
     
     $roas["locallyAddedAssertions"]["prefixAssertions"][$k]["asn"] = trim ($_asn[0], "AS");
     $roas["locallyAddedAssertions"]["prefixAssertions"][$k]["prefix"] = $_prefix;
-    $roas["locallyAddedAssertions"]["prefixAssertions"][$k]["maxPrefixLength"] = ($_asn[0] != "AS0" ? $_maxlength : 32);
+    $roas["locallyAddedAssertions"]["prefixAssertions"][$k]["maxPrefixLength"] = ($_asn[0] != "AS0" ? $_maxlength : MAX_LEN_IPV4_AS0);
     $roas["locallyAddedAssertions"]["prefixAssertions"][$k]["comment"] = "$web_registry_url/data/inetnum/$prefix[1]_$prefix[2]";
     $roas["locallyAddedAssertions"]["prefixAssertions"][$k]["source"] = "$_ta";
     $roas["locallyAddedAssertions"]["prefixAssertions"][$k]["mnt-by"] = "$_mnt";
diff --git a/roagen.php b/roagen.php
index d818826..cf90721 100755
--- a/roagen.php
+++ b/roagen.php
@@ -1,5 +1,7 @@
 <?php
 
+// Load lib files.
+require ("lib/constants.php");
 require ("lib/define.php");
 require ("lib/functions.php");
 
@@ -97,7 +99,7 @@ foreach ($raw_array as $sub_array)
 
     $roas["roas"][$k]["asn"] = $_asn[0];
     $roas["roas"][$k]["prefix"] = $_prefix;
-    $roas["roas"][$k]["maxLength"] = ($_asn[0] != "AS0" ? $_maxlength : 128);
+    $roas["roas"][$k]["maxLength"] = ($_asn[0] != "AS0" ? $_maxlength : MAX_LEN_IPV6_AS0);
     $roas["roas"][$k]["ta"] = $_ta;
 
     $k++;
@@ -187,7 +189,7 @@ foreach ($raw_array as $sub_array)
 
     $roas["roas"][$k]["asn"] = $_asn[0];
     $roas["roas"][$k]["prefix"] = $_prefix;
-    $roas["roas"][$k]["maxLength"] = ($_asn[0] != "AS0" ? $_maxlength : 32);
+    $roas["roas"][$k]["maxLength"] = ($_asn[0] != "AS0" ? $_maxlength : MAX_LEN_IPV4_AS0);
     $roas["roas"][$k]["ta"] = $_ta;
 
     $k++;