diff --git a/src/vmm_unix.ml b/src/vmm_unix.ml index ec567c7..588f9fb 100644 --- a/src/vmm_unix.ml +++ b/src/vmm_unix.ml @@ -146,6 +146,8 @@ let create_tap bridge = in let tap = find_n 0 in Bos.OS.Cmd.run Bos.Cmd.(v "ip" % "tuntap" % "add" % "mode" % "tap" % tap) >>= fun () -> + (* TODO maybe: ip link set $tap master $bridge -- no brctl *) + (* TODO also needed? ip link set dev $tap up -- or is it auto-up? *) Bos.OS.Cmd.run Bos.Cmd.(v "brctl" % "addif" % bridge % tap) >>= fun () -> Ok tap