From be83686a229b8fa1fbc4abfd9c8e95647c5de001 Mon Sep 17 00:00:00 2001
From: Hannes Mehnert <hannes@mehnert.org>
Date: Fri, 3 Apr 2020 17:29:46 +0200
Subject: [PATCH] Vmm_unix: fix ip tuntap command (provide tap name earlier),
 also set link up

---
 src/vmm_unix.ml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/vmm_unix.ml b/src/vmm_unix.ml
index aea6176..4200eb3 100644
--- a/src/vmm_unix.ml
+++ b/src/vmm_unix.ml
@@ -145,9 +145,9 @@ let create_tap bridge =
       | Ok _ -> find_n (succ x)
     in
     let tap = find_n 0 in
-    Bos.OS.Cmd.run Bos.Cmd.(v "ip" % "tuntap" % "add" % "mode" % "tap" % tap) >>= fun () ->
+    Bos.OS.Cmd.run Bos.Cmd.(v "ip" % "tuntap" % "add" % tap % "mode" % "tap") >>= fun () ->
     (* TODO maybe: ip link set $tap master $bridge -- no brctl *)
-    (* TODO also needed? ip link set dev $tap up -- or is it auto-up? *)
+    Bos.OS.Cmd.run Bos.Cmd.(v "ip" % "link" % "set" % "dev" % tap % "up") >>= fun () ->
     Bos.OS.Cmd.run Bos.Cmd.(v "brctl" % "addif" % bridge % tap) >>= fun () ->
     Ok tap