reynir/bornhack-website
1
0
Fork 0
Code Issues Pull requests 1 Releases Wiki Activity

ShopTicket: use @property instead of get_orp() method

Browse source 
This looks much more natural when being used from inside templates.
This commit is contained in:
Florian Klink 2019-08-08 21:05:55 +02:00
parent 9dd6b0b23c
commit 95e04b3741
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/profiles/templates/tickets/ticket_list.html
View file

@ -40,7 +40,7 @@
<td> <td>
{{ ticket.product.name }} {{ ticket.product.name }}
<td> <td>
{% if ticket.ticket_type.single_ticket_per_product %}{{ ticket.get_orp.quantity }} &times; {% endif %} {% if ticket.ticket_type.single_ticket_per_product %}{{ ticket.orp.quantity }} &times; {% endif %}
{{ ticket.product.price|currency }} {{ ticket.product.price|currency }}
<td> <td>
{% if ticket.used %} {% if ticket.used %}

6
src/tickets/models.py
View file

@ -93,8 +93,7 @@ class BaseTicket(CampRelatedModel, UUIDModel):
formatdict = {"ticket": self} formatdict = {"ticket": self}
if self.ticket_type.single_ticket_per_product and self.shortname == "shop": if self.ticket_type.single_ticket_per_product and self.shortname == "shop":
orp = self.get_orp() formatdict["quantity"] = self.orp.quantity
formatdict["quantity"] = orp.quantity
return generate_pdf_letter( return generate_pdf_letter(
filename="{}_ticket_{}.pdf".format(self.shortname, self.pk), filename="{}_ticket_{}.pdf".format(self.shortname, self.pk),
@ -165,5 +164,6 @@ class ShopTicket(BaseTicket):
def shortname(self): def shortname(self):
return "shop" return "shop"
def get_orp(self): @property
def orp(self):
return OrderProductRelation.objects.get(product=self.product, order=self.order) return OrderProductRelation.objects.get(product=self.product, order=self.order)