reynir/bornhack-website
1
0
Fork 0
Code Issues Pull requests 1 Releases Wiki Activity

remove debug print and handle creation cases in signal handler

Browse source
This commit is contained in:
Thomas Steen Rasmussen 2018-04-09 23:24:36 +02:00
parent edcf363027
commit 9b8e72a3c0
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/profiles/signal_handlers.py
View file

@ -25,7 +25,6 @@ def profile_pre_save(sender, instance, **kwargs):
original = sender.objects.get(pk=instance.pk) original = sender.objects.get(pk=instance.pk)
except sender.DoesNotExist: except sender.DoesNotExist:
original = None original = None
logger.debug("inside profile_pre_save with instance.nickserv_username=%s and original.nickserv_username=%s" % (instance.nickserv_username, original.nickserv_username))
public_credit_name_changed(instance, original) public_credit_name_changed(instance, original)
nickserv_username_changed(instance, original) nickserv_username_changed(instance, original)
@ -35,11 +34,11 @@ def public_credit_name_changed(instance, original):
""" """
Checks if a users public_credit_name has been changed, and triggers a public_credit_name_changed event if so Checks if a users public_credit_name has been changed, and triggers a public_credit_name_changed event if so
""" """
if original.public_credit_name == instance.public_credit_name: if original and original.public_credit_name == instance.public_credit_name:
# public_credit_name has not been changed # public_credit_name has not been changed
return return
if original.public_credit_name and not original.public_credit_name_approved: if original and original.public_credit_name and not original.public_credit_name_approved:
# the original.public_credit_name was not approved, no need to notify again # the original.public_credit_name was not approved, no need to notify again
return return
@ -61,7 +60,7 @@ def nickserv_username_changed(instance, original):
Check if profile.nickserv_username was changed, and uncheck irc_channel_acl_ok if so Check if profile.nickserv_username was changed, and uncheck irc_channel_acl_ok if so
This will be picked up by the IRC bot and fixed as needed This will be picked up by the IRC bot and fixed as needed
""" """
if instance.nickserv_username and instance.nickserv_username != original.nickserv_username: if instance.nickserv_username and original and instance.nickserv_username != original.nickserv_username:
logger.debug("profile.nickserv_username changed for user %s, setting irc_channel_acl_ok=False" % instance.user.username) logger.debug("profile.nickserv_username changed for user %s, setting irc_channel_acl_ok=False" % instance.user.username)
# find team memberships for this user # find team memberships for this user