parallel: --keep-order with --(n)onall: Sort output based on sshlogins.

doc/release_new_version

@@ -208,6 +208,9 @@ available for download at: http://ftp.gnu.org/gnu/parallel/
 
 New in this release:
 
+* Got CPUs to burn? Put 'em to work with GNU parallel
+  http://baoilleach.blogspot.dk/2013/11/got-cpus-to-burn-put-em-to-work-with.html
+
 * Parallel rsync
   http://pastebin.com/JmnB9ffq
 

src/parallel

@@ -122,8 +122,9 @@ if($opt::filter_hosts and (@opt::sshlogin or @opt::sshloginfile)) {
     my $cmd = "cat $tmpfile | $0 -j0 --timeout 5 -s 1000 --joblog - --plain --delay 0.1 --retries 3 --tag --tagstring {1} --colsep '\t' -k eval {2} 2>/dev/null";
     ::debug($cmd."\n");
     open(my $host_fh, "-|", $cmd) || ::die_bug("parallel host check: $cmd");
-    my (%ncores, %ncpus, %time_to_login, %maxlen, %echo);
+    my (%ncores, %ncpus, %time_to_login, %maxlen, %echo, @down_hosts);
     while(<$host_fh>) {
+	chomp;
 	my @col = split /\t/, $_;
 	if(defined $col[6]) {
 	    # This is a line from --joblog
@@ -143,7 +144,8 @@ if($opt::filter_hosts and (@opt::sshlogin or @opt::sshloginfile)) {
 		# exit == 255 or signal == 15: ssh failed
 		# Remove sshlogin
 		::debug("--filtered $host\n");
-		delete $Global::host{$host};
+		push(@down_hosts, $host);
+		@down_hosts = uniq(@down_hosts);
 	    } elsif($col[6] eq "127") {
 		# signal == 127: parallel not installed remote
 		# Set ncpus and ncores = 1
@@ -191,6 +193,8 @@ if($opt::filter_hosts and (@opt::sshlogin or @opt::sshloginfile)) {
     }
     close $host_fh;
     unlink $tmpfile;
+    delete @Global::host{@down_hosts};
+    @down_hosts and ::warning("Removed @down_hosts\n");
     while (my ($sshlogin, $obj) = each %Global::host) {
 	$ncpus{$sshlogin} or ::die_bug("ncpus missing: ".$obj->serverlogin());
 	$ncores{$sshlogin} or ::die_bug("ncores missing: ".$obj->serverlogin());
@@ -204,12 +208,16 @@ if($opt::filter_hosts and (@opt::sshlogin or @opt::sshloginfile)) {
 	$obj->set_time_to_login($time_to_login{$sshlogin});
         $obj->set_maxlength($maxlen{$sshlogin});
 	::debug("Timing from -S:$sshlogin ncpus:$ncpus{$sshlogin} ncores:$ncores{$sshlogin} ",
-		"time_to_login:$time_to_login{$sshlogin} maxlen:$maxlen{$sshlogin}");
+		"time_to_login:$time_to_login{$sshlogin} maxlen:$maxlen{$sshlogin}\n");
     }
 }
 
 if($opt::nonall or $opt::onall) {
+    onall();
+    wait_and_exit(min(undef_as_zero($Global::exitstatus),254));
+}
 
+sub onall {
 # TODO --transfer foo/./bar --cleanup
 # multiple --transfer and --basefile with different /./
 
@@ -241,6 +249,7 @@ if($opt::nonall or $opt::onall) {
 	     ((defined $opt::P) ? "-P $opt::P" : ""),
 	     ((defined $opt::u) ? "-u" : ""),
 	     ((defined $opt::group) ? "-g" : ""),
+	     ((defined $opt::keeporder) ? "--keeporder" : ""),
 	     ((defined $opt::D) ? "-D" : ""),
 	     ((defined $opt::plain) ? "--plain" : ""),
 	     ((defined $opt::max_chars) ? "--max-chars ".$opt::max_chars : ""),
@@ -250,6 +259,7 @@ if($opt::nonall or $opt::onall) {
 	     ((defined $opt::u) ? "-u" : ""),
 	     ((defined $opt::group) ? "-g" : ""),
 	     ((defined $opt::files) ? "--files" : ""),
+	     ((defined $opt::keeporder) ? "--keeporder" : ""),
 	     ((defined $opt::colsep) ? "--colsep ".shell_quote($opt::colsep) : ""),
 	     ((@opt::v) ? "-vv" : ""),
 	     ((defined $opt::D) ? "-D" : ""),
@@ -263,7 +273,8 @@ if($opt::nonall or $opt::onall) {
     open(my $parallel_fh, "|-", "$0 --no-notice -j0 $options") ||
 	::die_bug("This does not run GNU Parallel: $0 $options");
     my @joblogs;
-    for my $sshlogin (values %Global::host) {
+    for my $host (sort keys %Global::host) {
+	my $sshlogin = $Global::host{$host};
 	my $joblog = tmp_joblog($opt::joblog);
 	if($joblog) {
 	    push @joblogs, $joblog;
@@ -290,7 +301,6 @@ if($opt::nonall or $opt::onall) {
 	close $fh;
 	unlink($joblog);
     }
-    wait_and_exit(min(undef_as_zero($Global::exitstatus),254));
 }
 
 
@@ -725,7 +735,7 @@ sub options_hash {
 	 "gnu" => \$opt::gnu,
 	 "xapply" => \$opt::xapply,
 	 "bibtex" => \$opt::bibtex,
-	 "nonotice|no-notice" => \$opt::no_notice,
+	 "nn|nonotice|no-notice" => \$opt::no_notice,
 	 # xargs-compatibility - implemented, man, testsuite
 	 "max-procs|P=s" => \$opt::P,
 	 "delimiter|d=s" => \$opt::d,
@@ -2443,6 +2453,11 @@ sub show_limits {
 
 sub __GENERIC_COMMON_FUNCTION__ {}
 
+sub uniq {
+    # Remove duplicates and return unique values
+    return keys %{{ map { $_ => 1 } @_ }};
+}
+
 sub min {
     # Returns:
     #   Minimum value of array

src/parallel.pod

@@ -704,6 +704,10 @@ to see the difference:
   parallel -j4 sleep {}\; echo {} ::: 2 1 4 3
   parallel -j4 -k sleep {}\; echo {} ::: 2 1 4 3
 
+If used with B<--onall> or B<--nonall> output will be sorted according
+to sshlogin.
+
+
 =item B<-L> I<max-lines>
 
 When used with B<--pipe>: Read records of I<max-lines>.

src/parallel.texi

@@ -755,6 +755,9 @@ to see the difference:
   parallel -j4 -k sleep {}\; echo {} ::: 2 1 4 3
 @end verbatim
 
+If used with @strong{--onall} or @strong{--nonall} output will be sorted according
+to sshlogin.
+
 @item @strong{-L} @emph{max-lines}
 @anchor{@strong{-L} @emph{max-lines}}
 

testsuite/tests-to-run/parallel-remote1.sh

@@ -24,6 +24,6 @@ echo '### test --timeout --retries'
   parallel -j0 --timeout 5 --retries 3 -k ssh {} echo {} ::: 192.168.1.197 8.8.8.8 n m o c f w
 
 echo '### test --filter-hosts with server w/o ssh, non-existing server, and 5 proxied through the same'
-  parallel -S 192.168.1.197,8.8.8.8,n,m,o,c,f,w --filter-hosts --nonall --tag echo | sort
+  parallel -S 192.168.1.197,8.8.8.8,n,m,o,c,f,w --filter-hosts --nonall -k --tag echo
 
 EOF