valberg
  • Joined on 2017-09-24
valberg closed issue data.coop/membersystem#38 2024-08-02 22:57:51 +00:00
Setup new environment variables
valberg pushed to main at data.coop/ansible 2024-08-02 22:56:27 +00:00
3689eb7687 Add stripe secrets.
valberg pushed to main at data.coop/ansible 2024-08-02 22:53:07 +00:00
717db9055c Merge pull request 'Update environment variables re: data.coop/membersystem#38' (#216) from benjaoming/ansible:membersystem-envs into main
5ff603393b Update roles/docker/defaults/main.yml
c00ab53269 Update environment variables re: data.coop/membersystem#38
Compare 3 commits »
valberg merged pull request data.coop/ansible#216 2024-08-02 22:53:05 +00:00
Update environment variables re: https://git.data.coop/data.coop/membersystem/issues/38
valberg pushed to membersystem-envs at benjaoming/ansible 2024-08-02 22:52:39 +00:00
5ff603393b Update roles/docker/defaults/main.yml
valberg deleted branch waiting-list from benjaoming/membersystem 2024-07-31 22:50:43 +00:00
valberg pushed to main at data.coop/membersystem 2024-07-31 22:49:53 +00:00
865bc6c7bd New WaitingListEntry (#33)
valberg merged pull request data.coop/membersystem#33 2024-07-31 22:49:49 +00:00
New WaitingListEntry
valberg approved data.coop/membersystem#33 2024-07-31 22:49:38 +00:00
New WaitingListEntry
valberg commented on pull request data.coop/membersystem#32 2024-07-31 22:44:20 +00:00
Changes to payment models

Ah yes! I can vouch for it - we use it at $WORK without issues

valberg commented on pull request data.coop/membersystem#32 2024-07-31 22:43:09 +00:00
Changes to payment models

Yeah the one being removed is the "correct" way which I found at https://github.com/juftin/hatch-pip-compile/blob/main/docs/upgrading.md

valberg commented on pull request data.coop/membersystem#32 2024-07-31 22:37:36 +00:00
Changes to payment models

I did not do it on purpose no 😊 my all means remove it if it is isn't being used

valberg commented on pull request data.coop/membersystem#33 2024-07-31 22:29:50 +00:00
New WaitingListEntry

I think having explicit imports is more readable and gives me an overview of what the module is interfacing with.

I think we can debate this forever :P

I would say that we should go with "do…

valberg commented on pull request data.coop/membersystem#33 2024-07-31 22:03:42 +00:00
New WaitingListEntry

Well, yes. I mostly use for instance from django.db import models in my own models modules, because it is a standard - but I actually would love to be more explicit everywhere.

When push…

valberg suggested changes for data.coop/membersystem#33 2024-07-31 21:56:34 +00:00
New WaitingListEntry

Nice! I just have two things.

valberg commented on pull request data.coop/membersystem#33 2024-07-31 21:52:45 +00:00
New WaitingListEntry

I'm against importing whole modules.

valberg commented on pull request data.coop/membersystem#33 2024-07-31 21:51:28 +00:00
New WaitingListEntry

So apparently the difference is a meager 6MB. The only thing we want is to have the requirements file when installing dependencies and then copy stuff in. I've done that in https://git.data.coop/da

valberg pushed to main at data.coop/membersystem 2024-07-31 21:48:45 +00:00
0cf579c5f6 Update dockerfile to using bookworm, and to avoid invalidating cache unless updating requirements.
valberg pushed to main at data.coop/membersystem 2024-07-31 21:26:48 +00:00
7a3a629d6f Update requirements compilation to use hatch-pip-compile.