data.coop/ansible
8
3
Fork 7
Code Issues 52 Pull requests 10 Projects 1 Releases Wiki Activity

Add README.md #127

Merged
benjaoming merged 13 commits from readme into main 2022-11-29 13:58:39 +00:00
Conversation 2 Commits 13 Files changed 1 +105
samsapti commented 2022-11-25 22:32:45 +00:00
Owner
Copy link

Reviews/suggestions for changes are welcome.

Closes #59.

Reviews/suggestions for changes are welcome. Closes #59.
samsapti added 1 commit 2022-11-25 22:32:45 +00:00
samsapti force-pushed readme from b6c1608a58 to 7a1e71e96e 2022-11-25 22:34:19 +00:00 Compare
samsapti force-pushed readme from 7a1e71e96e to 62d5a3ccca 2022-11-25 22:36:56 +00:00 Compare
samsapti added 2 commits 2022-11-26 15:32:15 +00:00
samsapti added 1 commit 2022-11-26 19:28:27 +00:00
samsapti added 1 commit 2022-11-26 21:50:39 +00:00
samsapti added 1 commit 2022-11-27 16:20:47 +00:00
samsapti commented 2022-11-27 16:21:49 +00:00
Author
Owner
Copy link

Should we merge this?

CC: @valberg, @reynir

Should we merge this? CC: @valberg, @reynir
samsapti added 1 commit 2022-11-27 16:34:04 +00:00
samsapti added 1 commit 2022-11-27 16:35:48 +00:00
samsapti added 1 commit 2022-11-27 20:01:05 +00:00 
This reverts commit bef767ebd8.
benjaoming approved these changes 2022-11-28 16:57:00 +00:00
benjaoming left a comment
Owner
Copy link

LGTM 💯 Really nice and easy to read. Would suggest til specify the two roles more clearly in the beginning.

LGTM 💯 Really nice and easy to read. Would suggest til specify the two roles more clearly in the beginning.
README.md Outdated
@ -0,0 +10,4 @@
Ansible playbook uses two custom-made roles (in the `roles/` directory).
The script has options to deploy only one of the roles, which are namely
`ubuntu_base` and `docker`, the latter of which is for deploying the
services themselves using Docker containers. Select services only can
benjaoming commented 2022-11-28 16:55:26 +00:00
Owner
Copy link

This is really good! Suggesting this:

Ansible playbook uses two custom-made roles (in the roles/ directory):

  • ubuntu_base: ...
  • docker: deploying the services themselves using Docker containers

Select services only can also be specified. By default, the script deploys everything.

This is really good! Suggesting this: > Ansible playbook uses two custom-made roles (in the `roles/` directory): > > * `ubuntu_base`: ... > * `docker`: deploying the services themselves using Docker containers > > Select services only can also be specified. By default, the script deploys everything.
👍 1
samsapti commented 2022-11-28 17:14:56 +00:00
Author
Owner
Copy link

I agree, your suggestion looks a bit cleaner 👍

I agree, your suggestion looks a bit cleaner 👍
samsapti marked this conversation as resolved
samsapti added 1 commit 2022-11-28 17:20:22 +00:00
samsapti requested review from benjaoming 2022-11-28 17:53:53 +00:00
samsapti added 1 commit 2022-11-28 17:56:37 +00:00
samsapti requested review from Owners 2022-11-28 18:00:59 +00:00
samsapti removed review request for Owners 2022-11-28 18:01:05 +00:00
samsapti changed title from Add README.md to WIP: Add README.md 2022-11-28 18:01:07 +00:00
samsapti changed title from WIP: Add README.md to Add README.md 2022-11-28 18:01:12 +00:00
samsapti requested review from valberg 2022-11-28 18:01:28 +00:00
samsapti requested review from decibyte 2022-11-28 18:01:28 +00:00
samsapti requested review from reynir 2022-11-28 18:01:28 +00:00
valberg reviewed 2022-11-28 18:24:46 +00:00
README.md Outdated
@ -0,0 +20,4 @@
Here is a summary of the options that can be used with the script:
```console
$ ./deploy.sh # deploy everything
valberg commented 2022-11-28 18:24:46 +00:00
Owner
Copy link

Just for better rendering: can we put comments on the preceding line and have a newline between each comman e?

Just for better rendering: can we put comments on the preceding line and have a newline between each comman e?
👍 1
samsapti commented 2022-11-28 18:31:49 +00:00
Author
Owner
Copy link

Done 👍

Done 👍
samsapti marked this conversation as resolved
samsapti added 1 commit 2022-11-28 18:24:56 +00:00
samsapti added 1 commit 2022-11-28 18:31:38 +00:00
valberg approved these changes 2022-11-28 19:24:37 +00:00
valberg commented 2022-11-28 19:24:45 +00:00
Owner
Copy link

Merge it!

Merge it!
benjaoming approved these changes 2022-11-29 13:58:32 +00:00
benjaoming left a comment
Owner
Copy link

Renders well, very pretty document :)

Renders well, very pretty document :)
benjaoming merged commit 97e5f264f9 into main 2022-11-29 13:58:39 +00:00
samsapti removed review request for decibyte 2022-11-29 17:18:53 +00:00
samsapti removed review request for reynir 2022-11-29 17:18:55 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
valberg
benjaoming
Labels
Clear labels   
Blocked

Something is blocking progress

  
Existing Service

Issues/improvements regarding existing services

  
Infrastructure Issue

Infrastructure issue that needs investigation or time to fix

  
Refactor

Refactoring of files / file structure or other improvements

  
Security Hardening

Non-verified / non-critical security improvements

  
Security Issue

Urgent security issue that needs to be fixed ASAP

  
Service Idea

Ideas for new services

  
Service Removal

Removal of services for one reason or another

  
Upgrade service
No labels
Blocked
Existing Service
Infrastructure Issue
Refactor
Security Hardening
Security Issue
Service Idea
Service Removal
Upgrade service
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: data.coop/ansible#127
No description provided.
Delete branch "readme"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?