Fix invite text and add accounting context to translation messages #53

Merged
benjaoming merged 1 commit from benjaoming/membersystem:invite-fixes into main 2024-08-14 19:52:12 +00:00
Owner
No description provided.
benjaoming added 1 commit 2024-08-14 19:51:03 +00:00
Add accounting context to translation messages
Some checks failed
continuous-integration/drone/pr Build is failing
19ae307013
benjaoming reviewed 2024-08-14 19:52:00 +00:00
benjaoming left a comment
Author
Owner

Self-certified by local tests

Self-certified by local tests ✅
benjaoming merged commit f5feda3414 into main 2024-08-14 19:52:12 +00:00
benjaoming deleted branch invite-fixes 2024-08-14 19:52:12 +00:00
reynir reviewed 2024-08-15 07:41:17 +00:00
@ -57,3 +57,3 @@
c["domain"] = site.domain
c["site_name"] = site.name
c["protocol"] = "http" if self.request and not self.request.is_secure() else "https"
c["protocol"] = "https" # if self.request and not self.request.is_secure() else "https"
Owner

I think with our current nginx proxy setup we can check first for X-Forwarded-Proto header and otherwise do that. It may be brittle to check that header...

I think with our current nginx proxy setup we can check first for `X-Forwarded-Proto` header and otherwise do that. It may be brittle to check that header...
Author
Owner

You're right, it turns out the correct method is to define HOW the fact of https presence should be detected:

https://docs.djangoproject.com/en/5.0/ref/settings/#secure-proxy-ssl-header

You're right, it turns out the correct method is to define HOW the fact of https presence should be detected: https://docs.djangoproject.com/en/5.0/ref/settings/#secure-proxy-ssl-header
Owner

Ah awesome! Well spotted

Ah awesome! Well spotted
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: data.coop/membersystem#53
No description provided.