data.coop/membersystem

Fork 4

Refactoring things and doing stuff in a MVP way. #15

Merged

valberg merged 23 commits from vidir_refactor into master

2021-03-12 16:20:53 +00:00

valberg commented

2021-02-27 20:09:08 +00:00

Owner

No description provided.

valberg referenced this pull request

2021-02-28 23:23:12 +00:00

Test-Driven Development (TDD) #10

valberg commented

2021-02-28 23:27:39 +00:00

Author

Owner

Lidt screenshots af arbejdet. Det er meget MVP, men jeg tænker at det snart skal op og køre sådan alpha-staging-agtigt.

Screenshot_2021-03-01 – member data coop.png

36 KiB

Screenshot_2021-03-01 Login – example com.png

23 KiB

Screenshot_2021-03-01 Login – member data coop.png

22 KiB

Screenshot_2021-03-01 – member data coop.png

Screenshot_2021-03-01 Login – example com.png

Screenshot_2021-03-01 Login – member data coop.png

benjaoming commented

2021-03-02 08:21:19 +00:00

Owner

A masterpiece, I think it looks great and I look forward to enjoying the code in detail as well.

I'm thinking that we should merge this right meow -- the bigger the PR, the faster it should be reviewed and merged.

Aaaaand I guess it can also force any further inputs to be expressed in the form of PRs :)

A masterpiece, I think it looks great and I look forward to enjoying the code in detail as well. I'm thinking that we should merge this right meow -- the bigger the PR, the faster it should be reviewed and merged. Aaaaand I guess it can also force any further inputs to be expressed in the form of PRs :)

valberg commented

2021-03-02 09:33:49 +00:00

Author

Owner

A masterpiece, I think it looks great and I look forward to enjoying the code in detail as well.

Aww thanks!

I'm thinking that we should merge this right meow -- the bigger the PR, the faster it should be reviewed and merged.

Aaaaand I guess it can also force any further inputs to be expressed in the form of PRs :)

I totally agree, although I would like to get sending of mails working. This would mean that the ops side of things is up and running.

> A masterpiece, I think it looks great and I look forward to enjoying the code in detail as well. Aww thanks! > I'm thinking that we should merge this right meow -- the bigger the PR, the faster it should be reviewed and merged. > > Aaaaand I guess it can also force any further inputs to be expressed in the form of PRs :) I totally agree, although I would like to get sending of mails working. This would mean that the ops side of things is up and running.

benjaoming commented

2021-03-04 22:17:41 +00:00

Owner

Could we be using the FileBackend for now (for ops)?

https://docs.djangoproject.com/en/3.1/topics/email/#file-backend

Then emails could be a separate issue?

Could we be using the FileBackend for now (for ops)? https://docs.djangoproject.com/en/3.1/topics/email/#file-backend Then emails could be a separate issue?

valberg commented

2021-03-12 16:15:56 +00:00

Author

Owner

Gah, sorry, I actually got e-mails working. So will just make check pass and then merge.

valberg changed title from ~~WIP: Refactoring things and doing stuff in a MVP way.~~ to Refactoring things and doing stuff in a MVP way.

2021-03-12 16:17:19 +00:00

valberg referenced this pull request from a commit

2021-03-12 16:20:52 +00:00

Merge pull request 'Refactoring things and doing stuff in a MVP way.' (#15) from vidir_refactor into master Reviewed-on: https://git.data.coop/data.coop/membersystem/pulls/15

valberg merged commit 50e2ba642f into master

2021-03-12 16:20:53 +00:00