data.coop/membersystem
7
2
Fork 4
Code Issues 14 Pull requests 1 Releases Wiki Activity

Requirements pinning + some cleanup #36

Merged
valberg merged 4 commits from benjaoming/membersystem:requirements-and-cleanup into main 2024-07-31 21:17:01 +00:00
Conversation 0 Commits 4 Files changed 4 +40 -46
benjaoming commented 2024-07-24 09:34:25 +00:00
Owner
Copy link
No description provided.
benjaoming added 3 commits 2024-07-24 09:34:26 +00:00
Loose requirements pinning in pyproject.toml and re-generate requirements
Some checks failed
continuous-integration/drone/pr Build is failing
Details
a835db6ab9
benjaoming requested review from valberg 2024-07-24 09:34:33 +00:00
valberg requested changes 2024-07-24 11:54:01 +00:00
Dismissed
entrypoint.sh Outdated
@ -10,4 +3,0 @@
done
echo "PostgreSQL started"
valberg commented 2024-07-24 11:53:54 +00:00
Owner
Copy link

This check is not in docker-compose.yml. The "depends_on" does not ensure that the database has started yet. So I would think that we still need this?

This check is not in docker-compose.yml. The "depends_on" does not ensure that the database has started yet. So I would think that we still need this?
benjaoming commented 2024-07-24 12:05:51 +00:00
Author
Owner
Copy link

I thought I had added the healthcheck in the previous PR, but it's actually here

https://git.data.coop/data.coop/membersystem/pulls/33/files#issuecomment-2880

I thought I had added the healthcheck in the previous PR, but it's actually here https://git.data.coop/data.coop/membersystem/pulls/33/files#issuecomment-2880
benjaoming commented 2024-07-24 12:08:10 +00:00
Author
Owner
Copy link

3 PRs open at the same time is not ideal... sometimes jumping in and out of branches is dizzying 🥴

3 PRs open at the same time is not ideal... sometimes jumping in and out of branches is dizzying 🥴
benjaoming marked this conversation as resolved
benjaoming added 1 commit 2024-07-24 12:07:14 +00:00
Revert "Remove health-check for Postgres (it's now in docker-compose.yml)"
Some checks failed
continuous-integration/drone/pr Build is failing
Details
24f3c30a41 
This reverts commit 0f1211fa83.
valberg approved these changes 2024-07-31 21:16:56 +00:00
valberg merged commit f6d8f82065 into main 2024-07-31 21:17:01 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
valberg
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: data.coop/membersystem#36
No description provided.
Delete branch "benjaoming/membersystem:requirements-and-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?