data.coop/membersystem
7
2
Fork 4
Code Issues 14 Pull requests 1 Releases Wiki Activity

Requirements pinning + some cleanup #36

Merged
valberg merged 4 commits from benjaoming/membersystem:requirements-and-cleanup into main 2024-07-31 21:17:01 +00:00
Conversation 0 Commits 4 Files changed 4 -11
1 changed files with 0 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 0f1211fa83 - Show all commits

11
entrypoint.sh
View file

@ -1,16 +1,5 @@
#!/bin/sh
echo "Waiting for postgres..."
POSTGRES_PORT=${POSTGRES_PORT:-5432}
POSTGRES_HOST=${POSTGRES_HOST:-localhost}
while ! nc -z "$POSTGRES_HOST" "$POSTGRES_PORT"; do
sleep 0.1
done
echo "PostgreSQL started"
benjaoming marked this conversation as resolved Outdated
valberg commented 2024-07-24 11:53:54 +00:00
Outdated
Review
Copy link

This check is not in docker-compose.yml. The "depends_on" does not ensure that the database has started yet. So I would think that we still need this?

This check is not in docker-compose.yml. The "depends_on" does not ensure that the database has started yet. So I would think that we still need this?
benjaoming commented 2024-07-24 12:05:51 +00:00
Outdated
Review
Copy link

I thought I had added the healthcheck in the previous PR, but it's actually here

https://git.data.coop/data.coop/membersystem/pulls/33/files#issuecomment-2880

I thought I had added the healthcheck in the previous PR, but it's actually here https://git.data.coop/data.coop/membersystem/pulls/33/files#issuecomment-2880
benjaoming commented 2024-07-24 12:08:10 +00:00
Review
Copy link

3 PRs open at the same time is not ideal... sometimes jumping in and out of branches is dizzying 🥴

3 PRs open at the same time is not ideal... sometimes jumping in and out of branches is dizzying 🥴
# Only migrate, collectstatic and compilemessages if we are NOT in development
if [ -z "$DEBUG" ]; then
python src/manage.py migrate;