data.coop/website
8
1
Fork 6
Code Issues 10 Pull requests Releases Wiki Activity

Make links language-aware #101

Merged
benjaoming merged 3 commits from fix-redirects into main 2023-07-29 16:24:11 +00:00
Conversation 0 Commits 3 Files changed 10 +21 -23
samsapti commented 2023-07-29 15:42:17 +00:00
Owner
Copy link

Currently, when clicking on links they redirect to the absolute path, which is always the Danish version because only the English version has the /en/ path prefix. This PR makes links always generate with a path prefix if the current language has one. Including the logo.

Currently, when clicking on links they redirect to the absolute path, which is always the Danish version because only the English version has the `/en/` path prefix. This PR makes links always generate with a path prefix if the current language has one. Including the logo.
samsapti added 3 commits 2023-07-29 15:42:18 +00:00
Remove done todo
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
2cab915021
benjaoming reviewed 2023-07-29 15:45:25 +00:00
content/services/_index.da.md
@ -9,2 +8,3 @@
Alle tjenester er benævnt med [badges]({{< ref "/services/#badges" >}}), der deklarerer i hvor høj grad den
enkelte tjeneste lever op til [kerneprincipperne defineret i formålsparagraffen
i vores vedtægter](/rights/#-2-formål).
i vores vedtægter]({{< ref "/rights.md#-2-formål" >}}).
benjaoming commented 2023-07-29 15:45:25 +00:00
Owner
Copy link

Is this possible? :)

Is this possible? :)
samsapti commented 2023-07-29 15:47:06 +00:00
Author
Owner
Copy link

Surprisingly yes! Hugo knows how to find the file despite .da.md :)

Surprisingly yes! Hugo knows how to find the file despite `.da.md` :)
samsapti commented 2023-07-29 15:48:21 +00:00
Author
Owner
Copy link

It's on https://staging.data.coop btw

It's on https://staging.data.coop btw
benjaoming commented 2023-07-29 16:21:10 +00:00
Owner
Copy link

That's super nice! Being able to reference specific sections, supposing that it breaks loudly if there's an error.

That's super nice! Being able to reference specific sections, supposing that it breaks loudly if there's an error.
👍 1
benjaoming marked this conversation as resolved
benjaoming approved these changes 2023-07-29 16:23:57 +00:00
benjaoming left a comment
Owner
Copy link

Looks good and working on staging, awesome @samsapti 🥇

Looks good and working on staging, awesome @samsapti 🥇
👍 1
benjaoming merged commit 7ba1a77f5c into main 2023-07-29 16:24:11 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
benjaoming
Labels
Clear labels   
new-website

   
ui
No labels
new-website
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: data.coop/website#101
No description provided.
Delete branch "fix-redirects"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?