Use docker-compose #28

benjaoming · 2021-05-04T18:59:43Z

benjaoming commented

2021-05-04 18:59:43 +00:00

Fixes #27

laumann reviewed 2021-05-04 19:40:05 +00:00

README.md

					
				---------------

				@ -19,3 +28,3 @@

				``` {.sourceCode .bash}

				# Fetch .deb from Github

				wget https://github.com/gohugoio/hugo/releases/download/v0.80.0/hugo_extended_0.80.0_Linux-64bit.deb -O hugo_extended.deb

				wget https://github.com/gohugoio/hugo/releases/download/v0.80.0/hugo_extended_X.Y.Z_Linux-64bit.deb -O hugo_extended.deb

laumann commented

2021-05-04 19:33:17 +00:00

First-time contributor

[nit] The Dockerfile calls it hugo.deb but the docs say hugo_extended.deb - not a big point though.

[nit] The Dockerfile calls it `hugo.deb` but the docs say `hugo_extended.deb` - not a big point though.

benjaoming commented

2021-05-04 19:54:39 +00:00

This is also just manual instructions for someone that wants to run Hugo without Docker. I can imagine it can be easier for some folks that will find Docker discouraging. Like "what is even Docker!?" would maybe be the reaction of a frontend design who'd want to help :)

laumann commented

2021-05-04 20:08:23 +00:00

First-time contributor

I get that. I want to live without Docker :-)

benjaoming commented

2021-05-04 20:34:04 +00:00

I do too sometimes.. if dependencies are few and they are trustworthy .debs, it's fine for me at times.

benjaoming marked this conversation as resolved

docker-compose.yml Outdated

					
				@ -0,0 +21,4 @@

				    command: |

				      /bin/bash -c "

				        cd /code

				        hugo serve

laumann commented

2021-05-04 19:39:59 +00:00

First-time contributor

If I understand hugo correctly, then hugo serve uses the built-in server, and will build and serve everything from memory. So I don't think the build step is really necessary.

Per hugo server --help:

Hugo provides its own webserver which builds and serves the site.
While hugo server is high performance, it is a webserver with limited options.
Many run it in production, but the standard behavior is for people to use it
in development and use a more full featured server such as Nginx or Caddy.

I think using the built-in server is fine, as I don't think performance is a big concern right now.

I could be missing something though...

If I understand hugo correctly, then `hugo serve` uses the built-in server, and will build and serve everything from memory. So I don't think the build step is really necessary. Per `hugo server --help`: > Hugo provides its own webserver which builds and serves the site. > While hugo server is high performance, it is a webserver with limited options. > Many run it in production, but the standard behavior is for people to use it > in development and use a more full featured server such as Nginx or Caddy. I think using the built-in server is fine, as I don't think performance is a big concern right now. I could be missing something though...

benjaoming commented

2021-05-04 19:53:19 +00:00

It's only for development, yeah. The actual building is in .drone.yml.

It's only for development, yeah. The actual building is in `.drone.yml`.

laumann commented

2021-05-04 20:09:18 +00:00

First-time contributor

But then you could just omit the whole build service, right?

But then you could just omit the whole `build` service, right?

benjaoming commented

2021-05-04 20:29:45 +00:00

Ah yes, correct, I'll remove it, it's confusing.