Commit graph

902 commits

Author SHA1 Message Date
Michael Thorpe 52465c6142
Fix NULL pointer issue with Word2000 empty attributes.
This appears to be an issue with Word2000 handling of empty attributes.

A reproduction case can be seen here:

```
$ cat test.html
<html xmlns:o="urn:schemas-microsoft-com:office:office">
    <body>
        <table>
            <img class="" />
        </table>
    </body>
</html>

$ ./tidy --tidy-mark no --word-2000 yes test.html
line 1 column 1 - Warning: missing <!DOCTYPE> declaration
line 3 column 1 - Warning: <img> isn't allowed in <table> elements
line 2 column 1 - Info: <table> previously mentioned
line 1 column 57 - Warning: inserting missing 'title' element
line 3 column 1 - Warning: <img> lacks "alt" attribute
line 3 column 1 - Warning: <img> lacks "src" attribute
line 2 column 1 - Warning: trimming empty <table>
line 1 column 1 - Warning: <html> proprietary attribute "xmlns:o"
[2]    52405 segmentation fault  ./tidy --tidy-mark no --word-2000 yes test.html
```

This was called from 6f2fb6e0e7/src/clean.c (L1710).

(It is technically undefined behaviour to call strncmp with `NULL` pointers however).
2017-08-28 15:30:28 +01:00
Geoff R. McLane 951a65bdcf Improve doxy comment formating - no code changes 2016-09-11 17:20:43 +02:00
Geoff McLane 4edbc2424b Issue #428 - Bump to 5.3.11 for this merge 2016-09-11 17:09:09 +02:00
Geoff McLane d81a9ad901 Merge branch 'issue-428'
Conflicts:
	version.txt

This closes #428
2016-09-11 16:57:07 +02:00
Geoff McLane f1ac2dba58 Issue #449, merge #450 - Bump to 5.3.10 for this fix. 2016-09-11 15:50:42 +02:00
Geoff McLane a820f06cc8 Merge pull request #450 from marcoscaceres/as_attribute
Add support for link 'as' attribute (closes #449)
2016-09-11 15:46:38 +02:00
Geoff McLane 59d1fe4d72 Issue #454 - Clearly show `xsltproc' prereqisite, and other additions 2016-09-10 16:01:23 +02:00
Marcos Caceres e4ae9c064d Add support for link 'as' attribute (closes #449) 2016-08-23 18:46:04 +10:00
Geoff McLane 80e57b23bf Merge branch 'master' into issue-428
Conflicts:
	version.txt
2016-08-09 00:46:40 +02:00
Geoff McLane d2fc252598 Issue #443, merge #445 - Bump to 5.3.9 for this fix 2016-08-04 15:54:14 +02:00
Geoff McLane edafefb303 Merge pull request #445 from AdamMajer/fix_buffer_overflow
Fix static buffer overrrun (issue #443)
2016-08-04 15:50:57 +02:00
Geoff McLane 7631f25ed2 rebase issue-428 2016-08-02 18:10:19 +02:00
Adam Majer 50557a4f63 Fix static buffer overrrun (issue #443)
result[6] is a fixed array of size 6, but in the process
of copying data into it, we clobber the last allocated byte.

Simplify some of the code by not calling redundant functions.
2016-08-02 11:10:45 +02:00
Geoff McLane 09caae3b9c Issue #441 - add 'integrity' attribute.
Bumped to 5.3.8 for this change...

See also #418 and the merge #442

Thanks @bdesham and @dengeist...
2016-07-29 03:12:40 +02:00
Geoff McLane 9ea2539d36 Merge pull request #442 from bdesham/add-integrity-attribute
Add support for the "integrity" attribute
2016-07-29 02:55:54 +02:00
Benjamin Esham 54179386be Add support for the "integrity" attribute
This attribute may be used on "link" and "script" elements. See
http://www.w3.org/TR/2016/REC-SRI-20160623/#element-interface-extensions
2016-07-24 10:24:30 -04:00
Geoff McLane b26271e3f8 Adjust for removal of LICENSE.txt 2016-07-11 20:40:20 +02:00
Geoff McLane 4a483fd066 Issue #433 #429 #426 - bump to 5.3.7 - avoid crash when no doc
This bump also includes merge of #424 - licence fix, and #423 - add
__GLIBC__ to long HAS_FUTIME list.

And coincidentally #427 - an improved french translation!
2016-07-11 15:40:08 +02:00
Geoff McLane fa9472abec Merge pull request #433 from nijel/fix-crash-upstream
Avoid crash in tidyCleanAndRepair if document was not loaded
2016-07-11 15:22:08 +02:00
Geoff McLane 0d25772a93 Merge pull request #424 from danielhjames/patch-1
Update LICENSE.md
2016-07-11 15:20:27 +02:00
Geoff McLane f84effb1f5 Merge pull request #423 from pinotree/glibc
Set HAS_FUTIME=0 on any GNU libc platform
2016-07-11 15:17:42 +02:00
Geoff McLane 2b19d32a62 Merge pull request #427 from vargenau/master
Improve French translation.
2016-07-11 15:12:52 +02:00
Geoff McLane 3b73cc12c5 Issue #420 - Bump to 5.3.6 for this merge 2016-07-11 00:26:07 +02:00
Geoff McLane 517a2ea72d Merge pull request #420 from AdamMajer/compat_headers
Add compatibility headers
2016-07-11 00:23:01 +02:00
Michal Čihař 10281040ca Avoid crash in tidyCleanAndRepair if document was not loaded
These services can only be used when there is a document loaded, ie a
lexer created.  But really should not be calling a Clean and Repair
service with no doc!
2016-07-07 16:38:05 +02:00
Geoff McLane 685f7a6c5b Issue #428 - Avoid adding form to input if html5 2016-07-02 20:13:01 +02:00
Geoff McLane d332908e5d Issue #418 - Bump to 5.3.5 for this enum fix 2016-07-01 15:54:10 +02:00
Geoff McLane 8745f79177 Issue #418 - Ensure TidyAttrID enum exactly matches table.
The file tidyenum.h has an attribute ID enumeration that must exactly
match the attribute_defs[] table in attrs.c.

Originally some attempt was made to keep this enum in some sort of order
but that should now be totally abandonned. Any 'new' attribute
enumerations should be added just above the last N_TIDY_ATTRIBS, and
likewise in the table, to avoid this problem.
2016-07-01 15:52:02 +02:00
Daniel James fa06c0f44a Merge the two different license files and add contributors 2016-07-01 10:15:26 +01:00
Geoff McLane 6b3b1624ea Issue #422 - Bump to 5.3.4 for this fix. 2016-06-30 18:36:10 +02:00
Geoff McLane 7bec2c2082 Merge pull request #422 from sesom42/master
prevent buffer overflow in debug output
2016-06-30 18:32:55 +02:00
Marc-Etienne Vargenau fb10e80099 Improve French translation. 2016-06-29 18:12:26 +02:00
Adam Majer 30cc376f7b Add compatibility headers
In older versions of tidy, these headers were defined. Now, they are
renamed to tidybuffio.h and tidyplatform.h. This may be more of a
consistent naming scheme, but it breaks current software.

Re-add these headers and add compile time warning when such a header
is used.
2016-06-28 10:27:51 +02:00
Daniel James 5b23fd2f7d Update LICENSE.md
Change date to match LICENSE.txt
2016-06-27 15:18:10 +01:00
Pino Toscano 27143cc88e Set HAS_FUTIME=0 on any GNU libc platform
GNU libc does not have <sys/utime.h> but <utime.h>, so set HAS_FUTIME=0
for it; fixes build on non-Linux platforms using GNU libc.
2016-06-24 23:45:10 +02:00
Geoff McLane eca7688941 Issue #410 - Bump to 5.3.3 for this fix. 2016-06-18 18:57:09 +02:00
Geoff McLane 97700044ce Merge pull request #410 from gagern/varargs
Pair va_copy calls with va_end
2016-06-18 18:53:53 +02:00
Geoff McLane 676b36eff5 Issue #418 - add crossorigin attributes 2016-06-18 18:26:23 +02:00
Geoff McLane a734be5bdb Merge pull request #418 from bdesham/add-crossorigin-attribute
Add support for the HTML5 "crossorigin" attribute
2016-06-18 18:23:37 +02:00
Jens Tautenhahn 84fc451a78 prevent buffer overflow in debug output 2016-06-14 15:42:18 +02:00
Benjamin Esham 941b763a8d Add support for "crossorigin" on audio too 2016-06-08 19:40:15 -04:00
Benjamin Esham d9d8e92e52 Allow "crossorigin" on img, script, and video tags too 2016-06-07 22:29:57 -04:00
Benjamin Esham 9377f65f89 Add support for the HTML5 "crossorigin" attribute
This attribute can only be used on "link" elements.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link#Attributes
2016-06-07 22:20:10 -04:00
Martin von Gagern 04bc8d3195 Pair va_copy calls with va_end
According to the specs, each va_copy call should be matched by a va_end call
to ensure proper cleanup.  Furthermore, since message filters might iterate
over the list of arguments, we should hand a new copy to each filter.
2016-05-17 22:37:32 +02:00
Geoff McLane 60c1dd1744 Issue #396, #398 - Bump version.txt to 5.3.1 for this merge 2016-04-16 20:16:50 +02:00
Geoff McLane 0ab4c48711 Merge pull request #398 from rtack/issue-396
allow zero LI in UL when html5. fix for #396
2016-04-16 20:14:22 +02:00
Raphael Ackermann b704a4d0d4 allow zero LI in UL when html5. fix for #396 2016-04-08 23:08:56 +02:00
Geoff McLane fdf2169ebf Issue #394 - master reset to 5.3.0 2016-04-07 16:36:06 +02:00
Geoff McLane 0db9b32e22 Issue #390 - Bump to 5.1.52 for this indent fix 2016-04-04 18:14:33 +02:00
Geoff McLane 61a0a331fc Issue #390 - fix indent with --hide-endtags yes.
The problem was, with --hide-endtags yes, a conditional pprint buffer
flush had nothing to flush, thus the indent was not adjusted.

To track down this bug added a lot of MSVC Debug code, but is only
existing if some additional items defined, so has no effect on the release
code.

This, what feels like a good fix, was first reported about 12 years ago by
@OlafvdSpek in SF Bugs 563. Hopefully finally closed.
2016-04-04 18:13:08 +02:00